Closed
Bug 1117034
(Winconsistent-missing-override)
Opened 10 years ago
Closed 8 years ago
Correctly handle the clang -Winconsistent-missing-override warning
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
clang ToT has started to emit this warning. It's a good idea to mark these methods as MOZ_OVERRIDE anyway, so we should handle this by fixing our code accordingly.
Assignee | ||
Updated•10 years ago
|
Depends on: FAIL_ON_WARNINGS
Assignee | ||
Updated•10 years ago
|
Blocks: FAIL_ON_WARNINGS
No longer depends on: FAIL_ON_WARNINGS
Updated•10 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → Trunk
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → ehsan
Comment 1•10 years ago
|
||
When I first checked in the fix for bug 1123893, I accidentally copypasted *this* bug's bug # in its commit, as noted in bug 1123893 comment 4. I backed out & re-landed with the correct bug number. Adding "leave-open" here, so that this bug doesn't get auto-closed when my first faulty cset is merged to m-c.
Keywords: leave-open
Comment 2•10 years ago
|
||
In case it's useful to anyone else, here's a patch I'm using locally to prevent this warning from being treated as an error.
(This lets me build with clang nightly and with "ac_add_options --enable-warnings-as-errors" in my mozconfig. This warning is still emitted, it's just not treated as an error.)
Assignee | ||
Comment 3•10 years ago
|
||
In the interest of saving everyone's time, I landed a bunch of random fixes of this sort without review:
https://hg.mozilla.org/integration/mozilla-inbound/rev/45921e3d9773
Comment 6•8 years ago
|
||
I think we can call this FIXED now.
(I'm pretty sure this warning is treated as an error on TreeHerder now, and the only remaining instances of this warning are in 3rd-party code (where fixing is more complicated)).
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Alias: Winconsistent-missing-override
Blocks: Wsuggest-override
Comment 7•7 years ago
|
||
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in
before you can comment on or make changes to this bug.
Description
•