Closed
Bug 1118432
Opened 10 years ago
Closed 10 years ago
Mark virtual overridden functions as MOZ_OVERRIDE in WebRTC; r=jesup
Categories
(Core :: WebRTC, defect)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → ehsan
Blocks: Winconsistent-missing-override
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8544798 -
Flags: review?(rjesup)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8544798 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in WebRTC
Review of attachment 8544798 [details] [diff] [review]:
-----------------------------------------------------------------
::: media/webrtc/trunk/webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h
@@ +338,5 @@
> return 0;
> }
>
> virtual bool OnRecoveredPacket(const uint8_t* packet,
> + int packet_length) OVERRIDE {
This is upstream code... and it's fixed in webrtc branch 40 which will land soon. Please remove this from the patch.
Attachment #8544798 -
Flags: review?(rjesup) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
(In reply to Randell Jesup [:jesup] from comment #2)
> ::: media/webrtc/trunk/webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h
> @@ +338,5 @@
> > return 0;
> > }
> >
> > virtual bool OnRecoveredPacket(const uint8_t* packet,
> > + int packet_length) OVERRIDE {
>
> This is upstream code... and it's fixed in webrtc branch 40 which will land
> soon. Please remove this from the patch.
Done! Is there a bug number for the next WebRTC upstream code drop? Thanks!
Flags: needinfo?(rjesup)
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
|
|
Assignee | |
Comment 6•10 years ago
|
||
(In reply to Randell Jesup [:jesup] from comment #4)
> Bug 1109428
Wrong bug? :)
Flags: needinfo?(rjesup)
You need to log in
before you can comment on or make changes to this bug.
Description
•