Closed
Bug 1118547
Opened 10 years ago
Closed 10 years ago
Mark virtual overridden functions as MOZ_OVERRIDE in dom/canvas; r=baku
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → ehsan
Blocks: Winconsistent-missing-override
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8544908 -
Flags: review?(amarchesini)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8544908 [details] [diff] [review]
Mark virtual overridden functions as MOZ_OVERRIDE in dom/canvas
Review of attachment 8544908 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/canvas/WebGLContext.h
@@ +191,5 @@
>
> NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS_AMBIGUOUS(WebGLContext,
> nsIDOMWebGLRenderingContext)
>
> + virtual JSObject* WrapObject(JSContext* cx) MOZ_OVERRIDE = 0;
aCx
Attachment #8544908 -
Flags: review?(amarchesini) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•