Comment on attachment 8545013 [details] [diff] [review] Mark virtual overridden functions as MOZ_OVERRIDE in dom/plugins Review of attachment 8545013 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/plugins/base/PluginPRLibrary.h @@ +100,1 @@ > #endif which style of naming do we use here? pFun? bFuncs? :) @@ +114,4 @@ > virtual bool IsOOP() MOZ_OVERRIDE { return false; } > #if defined(XP_MACOSX) > + virtual nsresult IsRemoteDrawingCoreAnimation(NPP instance, bool *aDrawing) MOZ_OVERRIDE; > + virtual nsresult ContentsScaleFactorChanged(NPP instance, double aContentsScaleFactor) MOZ_OVERRIDE; type* {p,a,b}Var ::: dom/plugins/base/nsPluginStreamListenerPeer.cpp @@ +1259,5 @@ > ChannelRedirectProxyCallback() {} > > NS_DECL_ISUPPORTS > > + NS_IMETHODIMP OnRedirectVerifyCallback(nsresult result) MOZ_OVERRIDE aResult ::: dom/plugins/ipc/PluginInstanceChild.h @@ +145,5 @@ > > virtual bool > RecvPBrowserStreamConstructor(PBrowserStreamChild* aActor, const nsCString& url, > const uint32_t& length, const uint32_t& lastmodified, > + PStreamNotifyChild* notifyData, const nsCString& headers) MOZ_OVERRIDE; aVar @@ +544,5 @@ > void ClearAllSurfaces(); > > void Destroy(); > > + void ActorDestroy(ActorDestroyReason why) MOZ_OVERRIDE; aWhy ::: dom/plugins/ipc/PluginModuleParent.h @@ +216,5 @@ > > + virtual bool HasRequiredFunctions() MOZ_OVERRIDE; > + virtual nsresult AsyncSetWindow(NPP instance, NPWindow* window) MOZ_OVERRIDE; > + virtual nsresult GetImageContainer(NPP instance, mozilla::layers::ImageContainer** aContainer) MOZ_OVERRIDE; > + virtual nsresult GetImageSize(NPP instance, nsIntSize* aSize) MOZ_OVERRIDE; aType