Open Bug 1119246 Opened 10 years ago Updated 2 years ago

block non-local names in testsuite runs at the DNS level, rather than the socket connect level

Categories

(Core :: Networking: DNS, defect, P5)

defect

Tracking

()

People

(Reporter: froydnj, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-would-take])

Bug 995417 set things up so that during testsuite runs, we block any attempt to make a connection to a non-local host.  However, bugs like bug 1117979 show that even allowing non-local DNS requests can make things go orange-colored.

Bug 995417 comment 4 discouraged blocking things at the DNS level, with the concern that we then wouldn't be testing what we ship.  It might be worth revisiting that assumption.
We could presumably leverage network.dns.localDomains:
https://dxr.mozilla.org/mozilla-central/source/netwerk/dns/nsDNSService2.cpp#52

Which specifies a list of hosts to force-resolve to localhost. That + a pref for "crash resolving anything not in this list" would probably do it.
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #1)
> We could presumably leverage network.dns.localDomains:
> https://dxr.mozilla.org/mozilla-central/source/netwerk/dns/nsDNSService2.
> cpp#52
> 
> Which specifies a list of hosts to force-resolve to localhost. That + a pref
> for "crash resolving anything not in this list" would probably do it.

FTR, bug 1117979 is really just looking for a hostname resolution to *fail*, or really any other way to have a HTTP XHR in the test fire onerror.  So in addition to a list of hosts that are force-resolved it would be ideal if there was a list that force-failed without triggering the diagnostic crash.
Whiteboard: [necko-would-take]
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: -- → P5
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.