Closed Bug 112031 Opened 23 years ago Closed 4 years ago

Can't create user profile folder when use DBCS as user name

Categories

(Core :: Internationalization, defect, P3)

x86
Windows 98
defect

Tracking

()

RESOLVED INVALID
mozilla1.3alpha

People

(Reporter: kasumi, Assigned: jshin1987)

References

Details

(Keywords: intl, Whiteboard: [eta:8/16/2002])

Attachments

(2 files, 3 obsolete files)

tested on 2001-11-25-22-0.9.4ec OS = Win 98 1. Launch Profile manager 2. Click Create profile button and create a new user profile using DBCS as profile name. Such as "SHINN YU-ZA" in DBCS Katakana 3. Click Finish button 4. Check C:(maybe)Windows/Application Data/Mozilla/Profiles You will not be able to see folder "SHINN YU-ZA", you will have .slt file name as folder name instead. Expected: Create profile folder having DBCS profile name same as SBCS user name does
Keywords: topembed
*** Bug 112043 has been marked as a duplicate of this bug. ***
tested on 2001-11-26-06-trunk OS = Win XP Ja There is no problem to have folder having DBCS.
Keywords: intl
I might need to test using 2001-11-26-06-trunk on some English Windows OS. Please wait Yokoyama-san.
tested on 2001-11-26-06-trunk OS = Win 98 The result is the same as 2001-11-25-22-0.9.4ec Created holder is over written on existing folder which is created prior ec test having .slt file name as folder name.
Your comment #2 means it works in XP-JP so, is it a Win98 specific bug?
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla0.9.9
No. Happened on Win 2000 as well. I think this is regarding English Windows.
I take out topembed keyword since this is a general Double byte problem on US Windows system.
Keywords: topembed
Keywords: nsbeta1
Ideas: add code to check if the entered profile is a valid.
> You will not be able to see folder "SHINN YU-ZA", you will have .slt file > name as folder name instead. This makes me suspect nsLocalFile::Append(). Take a look at this: http://lxr.mozilla.org/mozilla/source/profile/src/nsProfile.cpp#1350 The fact the we're left with only the .slt directory and it's supposed to be the child dir of the user name (the one that's DBCS) makes me thing the Append() of a char* when the current leaf node was DBCS failed.
Target Milestone: mozilla0.9.9 → mozilla1.0
nsbeta1- per triage meeting
Keywords: nsbeta1nsbeta1-
Target Milestone: mozilla1.0 → mozilla1.0.1
Blocks: 157673
nsbta1+ for m1.2final
Keywords: nsbeta1-nsbeta1+
Whiteboard: [eta:8/16/2002]
Target Milestone: mozilla1.0.1 → mozilla1.2alpha
Target Milestone: mozilla1.2alpha → mozilla1.2beta
Attached patch Patch for XPCOM/IO (obsolete) (deleted) — Splinter Review
Attached patch Patch for History.dat ( db module ) (obsolete) (deleted) — Splinter Review
Attachment #105254 - Attachment is obsolete: true
With above patches, we can create/delete non-locale Profile names and file/directories. :)
Blocks: 112741
*** Bug 112741 has been marked as a duplicate of this bug. ***
Blocks: 154629
*** Bug 154629 has been marked as a duplicate of this bug. ***
Blocks: 101573
*** Bug 101573 has been marked as a duplicate of this bug. ***
bulk milestone change
Target Milestone: mozilla1.2beta → mozilla1.3alpha
Attached patch fixing indent (obsolete) (deleted) — Splinter Review
Attachment #105255 - Attachment is obsolete: true
cc david for his input.
why not use the charset converter for converting between utf8 and unicode? Or the string routines that do that, instead of adding new code to do it?
Attached patch Calling NS_ConvertUTF8toUCS2() (deleted) — Splinter Review
Oop, I didn't realize that we can call string routines from mork.......
Attachment #106038 - Attachment is obsolete: true
you might need to change what mork links against to use the string routines (so take care of mac, windows, and linux). The original author didn't want Mork to depend on anything else. I would much rather use existing libraries than rewrite everything for mork. Is doing this with a compile time flag really the right way to go? (the answer could be yes; I don't know). The alternative is to add a new interface to open unicode file names, or adding a boolean parameter that says file names are in utf8. That would involve changing all the callers, I guess, but it seems like you have to change the callers to encode the file names in utf8 anyway.
Comment on attachment 106041 [details] [diff] [review] Calling NS_ConvertUTF8toUCS2() r=bienvenu, but you need to make sure it builds on all platforms; as I mentioned before, we might not be linking in the right libs.
Attachment #106041 - Flags: review+
right, and depends on platform wchar might not be 2bytes
i18n triage team: nsbeta1-
Keywords: nsbeta1+nsbeta1-
I think both roy and me are off mozilla for more than 2 years. If these bugs are still here now, I think the real stauts is 'won't fix'. If you want to reopen it, please find a new owner for it first.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → WONTFIX
Mass Reassign Please excuse the spam
Assignee: tetsuroy → nobody
Mass Re-opening Bugs Frank Tang Closed on Wensday March 02 for no reason, all the spam is his fault feel free to tar and feather him
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Reassigning Franks old bugs to Jungshik Shin for triage - Sorry for spam
Assignee: nobody → jshin1987
Status: REOPENED → NEW
QA Contact: teruko → i18n
Status: NEW → RESOLVED
Closed: 20 years ago4 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: