Closed
Bug 1121348
Opened 10 years ago
Closed 10 years ago
[Stingray][Home] Hide filter buttons
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rexboy, Assigned: suchiu)
References
Details
(Whiteboard: [ft:conndevices] [ETA: 1/16])
Attachments
(1 file)
We'll not expose filter feature for now. Let's hide filter buttons.
|
||
Updated•10 years ago
|
Assignee: nobody → suchiu
|
Assignee | |
Comment 1•10 years ago
|
||
1. Add display none to filter button
2. Remove id and class name from Spacial_Navigator
3. Fix jshint error
Attachment #8550172 -
Flags: review?(rexboy)
|
Reporter | |
Comment 2•10 years ago
|
||
Comment on attachment 8550172 [details]
Pull Request
Looks good to me with a nit error.
Thanks a lot!
You may try update the nit error, and I to merge the patch for you.
Attachment #8550172 -
Flags: review?(rexboy) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
(In reply to KM Lee [:rexboy] (Away Dec. 26 ~ Jan. 4) from comment #2)
> Comment on attachment 8550172 [details]
> Pull Request
>
> Looks good to me with a nit error.
> Thanks a lot!
>
> You may try update the nit error, and I to merge the patch for you.
Thanks, I have modified the nit.
|
|
Reporter | |
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Comment 5•10 years ago
|
||
This landed without a bug number which can cause difficulty tracking history in the future. I've backed this out and re-landed with the proper commit message format.
Backout: https://github.com/mozilla-b2g/gaia/commit/d185d20f6137b7c564f682fcb3dbd3263aa68085
Re-land: https://github.com/mozilla-b2g/gaia/commit/e0cc056e8deec8a76c27d819f7669bf18f59e591
|
||
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•