Closed Bug 1149469 Opened 10 years ago Closed 10 years ago

[Stingray][Home] Filtering cards by group

Categories

(Firefox OS Graveyard :: Gaia::TV::Home, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::Home
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rexboy, Assigned: dwi2)

References

Details

Attachments

(1 file)

[gaia] dwi2:bug1149469 > mozilla-b2g:master
(deleted), text/x-github-pull-request
rexboy
: review+
rexboy
: feedback+
Details
As an user, I would like to filter out cards by category tab. We have 4 kinds of groups, namely TV, app, device, and dashboard. User can toggle a group and filter out cards that belong to that group.
Blocks: conn_priority
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
Depends on: 1162449
Comment on attachment 8605665 [details] [gaia] dwi2:bug1149469 > mozilla-b2g:master Hi Rex, Since this is not a small patch. I'd like to have your feedback first. In the mean time I am working on add unit tests for card_filter.js and filter_manager.js. Thanks
Attachment #8605665 - Flags: feedback?(rexboy)
Comment on attachment 8605665 [details] [gaia] dwi2:bug1149469 > mozilla-b2g:master It goes on a good direction. I haven't see tests in detail though. See some of my comments on Github.
Attachment #8605665 - Flags: feedback?(rexboy) → feedback+
Comment on attachment 8605665 [details] [gaia] dwi2:bug1149469 > mozilla-b2g:master Hi Rex, I've addressed your comments and added unit tests for filter_manager.js in two newer commits. Please help to review it. Thanks
Attachment #8605665 - Flags: review?(rexboy)
(In reply to Tzu-Lin Huang [:dwi2][:tzhuang] from comment #4) > Comment on attachment 8605665 [details] > [gaia] dwi2:bug1149469 > mozilla-b2g:master > > Hi Rex, > > I've addressed your comments and added unit tests for filter_manager.js in > two newer commits. Please help to review it. Thanks Sorry, it should be all in the latest commit.
Comment on attachment 8605665 [details] [gaia] dwi2:bug1149469 > mozilla-b2g:master Mostly looks good for me, But see my comments for some changes needed. Also please squash commits before landing.
Attachment #8605665 - Flags: review?(rexboy) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocks: 1166612
Whiteboard: [partner-cherry-pick]
Whiteboard: [partner-cherry-pick]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: