Closed Bug 1121550 Opened 10 years ago Closed 10 years ago

One-off button list header half visible when there's no one-off engine to display in the search panel

Categories

(Firefox :: Search, defect)

Product:
Firefox
Component:
Search
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 38
Iteration:
38.1 - 26 Jan
Tracking Flags:
Tracking Status
firefox36 --- unaffected
firefox37 --- verified
firefox38 --- verified

People

(Reporter: florian, Assigned: florian)

References

(Depends on 1 open bug)

Details

(Keywords: regression)

Attachments

(2 files)

Screenshot
(deleted), image/png
Details
Patch
(deleted), patch
Felipe
: review+
lmandel
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached image Screenshot (deleted) —
In bug 1109854 we changed a xul:hbox to a xul:deck. Now, because of bug 589569, the deck is half visible even when collapsed. See attached screenshot. Looking at this through DOM Inspector shows that the height of the collapsed deck is 7px, that is, the border top (1px) + padding top (3px) + padding bottom (3px).
Flags: firefox-backlog+
Attached patch Patch (deleted) — — Splinter Review
Using hidden instead of collapsed works around this. I would prefer if bug 589569 could be fixed, but we may have to go with a workaround.
Comment on attachment 8548993 [details] [diff] [review] Patch Review of attachment 8548993 [details] [diff] [review]: ----------------------------------------------------------------- just mention bug 589569 in a comment
Attachment #8548993 - Flags: review+
Hi Florian, can you provide a point value.
Assignee: nobody → florian
Status: NEW → ASSIGNED
Iteration: --- → 38.1 - 26 Jan
Flags: qe-verify?
Flags: needinfo?(florian)
Points: --- → 1
Flags: qe-verify?
Flags: qe-verify+
Flags: needinfo?(florian)
https://hg.mozilla.org/mozilla-central/rev/a46d323baa06
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
status-firefox38: affected → fixed
OS: Mac OS X → All
Hardware: x86 → All
Comment on attachment 8548993 [details] [diff] [review] Patch Approval Request Comment [Feature/regressing bug #]: bug 1109854 [User impact if declined]: the last search suggestion may be cut, see attachment 8548991 [details], when all one-off engines are hidden. [Describe test coverage new/current, TBPL]: on m-c, will be verified by QA [Risks and why]: very low, one line fix. [String/UUID change made/needed]: none.
Attachment #8548993 - Flags: approval-mozilla-aurora?
QA Contact: petruta.rasa
Verified that the last suggestion is not cut when all the one-click search engines are hidden using Nightly 38.0a1 2014-01-18 under Ubuntu 12.04 LTS 32-bit, Windows 7 64-bit and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
status-firefox38: fixed → verified
Comment on attachment 8548993 [details] [diff] [review] Patch Aurora+
Attachment #8548993 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified as fixed using Developer Edition 37.0a2 2014-01-21 under Ubuntu 12.04 LTS 32-bit, Windows 7 64-bit and Mac OS X 10.9.5.
status-firefox37: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: