Closed Bug 1123311 Opened 10 years ago Closed 10 years ago

"Search with" is displayed while search engine one-off buttons aren't, when clicking the search bar arrow

Categories

(Firefox :: Search, defect)

Product:
Firefox
Component:
Search
Version:
38 Branch
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Iteration:
39.1 - 9 Mar
Tracking Flags:
Tracking Status
firefox37 + verified
firefox38 + verified

People

(Reporter: phorea, Assigned: florian)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Patch
(deleted), patch
Details | Diff | Splinter Review
Reproduced using Nightly 38.0a1 2015-01-18 under Ubuntu 12.04 LTS 32-bit, Windows 7 64-bit and Mac OS X 10.9.5. Selecting the arrow from the search bar while there is nothing typed, results in a drop down containing "Search with" and "Change Search Settings" "Search with" shouldn't be shown, regression introduced by 1121550: Last good revision: cac6192956ab (2015-01-16) First bad revision: 369a8f14ccf8 (2015-01-17) Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cac6192956ab&tocha nge=369a8f14ccf8 Last good revision: 53d0b45c24c5 First bad revision: 369a8f14ccf8 Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=53d0b4 5c24c5&tochange=369a8f14ccf8
status-firefox37: --- → affected
status-firefox38: --- → affected
tracking-firefox37: --- → +
tracking-firefox38: --- → +
Flags: qe-verify+
Flags: firefox-backlog+
Keywords: regression
Points: --- → 1
This may be wontfix due to bug 1126250.
We should fix this in the interim (Firefox 37) even if we end up taking bug 1126250 later. Florian, can you take this?
Flags: needinfo?(florian)
Comment on attachment 8560050 [details] [diff] [review] patch, v2 Is this the patch you intended to attach? It looks like a backout of the patch adding the string.
Flags: needinfo?(florian)
Attachment #8560050 - Flags: review?(florian)
(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #2) > We should fix this in the interim (Firefox 37) even if we end up taking bug > 1126250 later. Florian, can you take this? I'll fix either this bug or bug 1126250 (which I expect to be pretty simple) in time for 37, yes.
Attached patch Patch (deleted) — — Splinter Review
Here's a patch to fix it if we need it. Not requesting review because it would directly conflict with a patch for bug 1126250 which I'm hoping to fix soon.
Attachment #8560050 - Attachment is obsolete: true
Florian - Assigning this one to you as you're going to fix the issue either here or in bug 1126250. Note that I would highly prefer to have this fixed this week while 37 is still Aurora.
Assignee: nobody → florian
Fixed by bug 1126250, right?
Flags: needinfo?(florian)
(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #8) > Fixed by bug 1126250, right? It's not exactly "fixed", but it's not a problem anymore, as this is now part of the intended behavior.
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(florian)
Resolution: --- → WONTFIX
Sounds like FIXED to me. I'll reword the summary if that helps :)
status-firefox37: affected → fixed
status-firefox38: affected → fixed
Resolution: WONTFIX → FIXED
Summary: "Search with" is also displayed when clicking the search bar arrow → "Search with" is displayed while search engine one-off buttons aren't, when clicking the search bar arrow
Iteration: --- → 39.1 - 9 Mar
QA Contact: petruta.rasa
Marking as verified by verification of bug 1126250.
Status: RESOLVED → VERIFIED
status-firefox37: fixed → verified
status-firefox38: fixed → verified
Mistakenly filed against Firefox 38 and should be instead 38 Branch. Sorry for the spam. dkl
Version: Firefox 38 → 38 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: