For now, the push_apk script ( https://hg.mozilla.org/build/mozharness/file/28e050ccc2aa/scripts/push_apk.py ) expect two arguments: --apk-x86 fennec-34.0b8.multi.android-i386.apk --apk-armv7 fennec-34.0b8.multi.android-arm.apk This won't work with the new apk filenames. The args should be renamed for something like; --apk-armv7-v9 --apk-armv7-v11 etc

I am going to take care of this bug or mentor someone.

Following the CS dictum of "once you generalize from 1 to 2, you should generalize to N", you might want to consider a different approach altogether, and have this driven by a manifest.

(In reply to Richard Newman [:rnewman] from comment #2) > Following the CS dictum of "once you generalize from 1 to 2, you should > generalize to N", you might want to consider a different approach > altogether, and have this driven by a manifest. Right, I reported bug 1122509 for this (I haven't been able to find one)

(In reply to Sylvestre Ledru [:sylvestre] from comment #0) > For now, the push_apk script ( > https://hg.mozilla.org/build/mozharness/file/28e050ccc2aa/scripts/push_apk. > py ) expect two arguments: > --apk-x86 fennec-34.0b8.multi.android-i386.apk --apk-armv7 > fennec-34.0b8.multi.android-arm.apk > > This won't work with the new apk filenames. > The args should be renamed for something like; > --apk-armv7-v9 > --apk-armv7-v11 > etc Hello :sylvestre, so currently in push_apk.py script I see two options: --apk-armv7 and --apk-armv6. I'm wondering if you meant to prefix these two with v9 and v11 respectively until a manifest solution is worked out? Let me know if that was the intention and I can submit a patch for this.

(In reply to Simarpreet Singh from comment #4) > (In reply to Sylvestre Ledru [:sylvestre] from comment #0) > Hello :sylvestre, so currently in push_apk.py script I see two options: > --apk-armv7 and --apk-armv6. I'm wondering if you meant to prefix these two > with v9 and v11 respectively until a manifest solution is worked out? Let me > know if that was the intention and I can submit a patch for this. No, prefixing won't work since we expect to have more and more apks in the future. So, we are going to use a manifest file for this but I don't think it has been implemented yet (cf bug 1122509). I am going to remove the good first bug since it is not ready yet. Sorry about that.

like 1122071, afaik, push_apk.sh is managed by relman these days. Sylvestre, do you need a hand adjusting the script to support new split apk file names or are you happy to continue mentoring/finishing this yourself? Let me know if I can assist in something here from releng side of things.

I am happy to do it myself (or mentor it) once the manifest is there! :) Thanks for the offer!

Because we don't have a manifest (yet?), because we have now 3 apks instead of 2, I am going to be lazy and have two arguments for armv7 apk. We need that stuff to land and we cannot wait for bug 1122509.

Looks like I did a mistake in the export of the patch. Fixed!

Comment on attachment 8573341 [details] [diff] [review] bug_1122076.diff https://hg.mozilla.org/build/mozharness/rev/6ece356e4c17

That works (tested with the last beta)