Closed Bug 1126371 Opened 10 years ago Closed 9 years ago

Check native FxA login works on 3.0

Categories

(Marketplace Graveyard :: General, defect, P4)

Avenir
All
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: ferjm, Unassigned)

References

Details

(Whiteboard: [marketplace-transition])

I am not sure when this changed, but IIRC we could consume an existing FxA login from the Marketplace. With a latest FxOS build (3.0) if I already logged in the device with my FxA and go to the Marketplace to buy a premium app I am asked to enter my FxA credentials again. I guess this is because the Marketplace is using the OAuth flow instead of the mozId one. IMHO this is user experience regression. Note that we explicitly mention in the Settings app that the user is signed in in the "Marketplace" and "Find My Device" (which actually wasn't completely true before this issue).
Do you guys know why we changed this behavior?
Flags: needinfo?(spenrose)
Flags: needinfo?(kumar.mcmillan)
Native flow is in testing for 2.1 and not on prod, since it wouldn't work on 2.0. It should work with everything in 2.1 onwards on marketplace stage, but we haven't really tested it yet in 3.0. Happy to leave this bug open to make sure that when the native flow lands in the marketplace we test on 3.0.
Blocks: 1088604
Flags: needinfo?(spenrose)
Flags: needinfo?(kumar.mcmillan)
Summary: Marketplace is no longer consuming device FxA login → Check native FxA login works on 3.0
C.f. https://bugzilla.mozilla.org/show_bug.cgi?id=1098519 , which should mean that FxA SSO is no longer dependent on the RP's choice of OAuth or mozId.
Priority: -- → P4
native flow is not working on 3.0 eng build (2015-01-25; 0f662dff)
Priority: P4 → --
Priority: -- → P4
Thanks for your responses. (In reply to Andy McKay [:andym] from comment #2) > Native flow is in testing for 2.1 and not on prod, since it wouldn't work on > 2.0. It should work with everything in 2.1 onwards on marketplace stage, but > we haven't really tested it yet in 3.0. > I am just curious. Is the limitation for 2.0 on the Marketplace or on the platform? AFAIK the mozId API should be available on 2.0 with FxA support. (In reply to krupa raj[:krupa] from comment #4) > native flow is not working on 3.0 eng build (2015-01-25; 0f662dff) Sorry, I am confused here. Are you referring to the Marketplace support to use the FxA native flow (mozId API) or the FxA native flow itself? (In reply to Sam Penrose from comment #3) > C.f. https://bugzilla.mozilla.org/show_bug.cgi?id=1098519 , which should > mean that FxA SSO is no longer dependent on the RP's choice of OAuth or > mozId. Thanks Sam, I'll comment on that bug.
(In reply to Fernando Jiménez Moreno [:ferjm] from comment #5) > I am just curious. Is the limitation for 2.0 on the Marketplace or on the > platform? AFAIK the mozId API should be available on 2.0 with FxA support. See bug 1028398
I tested it in Firefox OS 2.0 and I got same behavior as described in comment 0, both from Marketplace and in-app payments. This is really confusing and annoying for end users. Is there any plan to fix it?
I have re-tested with today master build, and the behavior is even more weird. When you try to buy an app, you are asked for a Firefox Account twice. Apparently one of them is in sync with Firefox Account registration for the device, and the other one for internal registration of Marketplace (I found it using a different Firefox Account each time)
(In reply to Marcelino Veiga Tuimil [:sonmarce] from comment #7) > I tested it in Firefox OS 2.0 and I got same behavior as described in > comment 0, both from Marketplace and in-app payments. This is really > confusing and annoying for end users. Is there any plan to fix it? Yes, please see the bugs under bug 1088604 which are awaiting QA signoff. Please also bug 1028398 as to why the earliest it will happen is 2.1.
(In reply to Andy McKay [:andym] from comment #6) > (In reply to Fernando Jiménez Moreno [:ferjm] from comment #5) > > I am just curious. Is the limitation for 2.0 on the Marketplace or on the > > platform? AFAIK the mozId API should be available on 2.0 with FxA support. > > See bug 1028398 Thanks Andy. Sorry for being such a pain, but I still don't understand :( Why is bug 1028398 avoiding the Marketplace to use the FxA native flow in 2.0 and how is situation different in 2.1? What we did in bug 1028398 is to make sure that we ask for the FxA password (only) the first time a non-preinstalled privileged app requests a FxA login. I believe the only extra thing that the Marketplace needs to do after bug 1028398 is to add the moz-firefox-accounts permission to its manifest.
I have filed bug 1128470 to track problem described in comment 8
Flags: needinfo?(amckay)
(In reply to Fernando Jiménez Moreno [:ferjm] from comment #11) > (In reply to Andy McKay [:andym] from comment #6) > > (In reply to Fernando Jiménez Moreno [:ferjm] from comment #5) > > > I am just curious. Is the limitation for 2.0 on the Marketplace or on the > > > platform? AFAIK the mozId API should be available on 2.0 with FxA support. > > > > See bug 1028398 > > Thanks Andy. Sorry for being such a pain, but I still don't understand :( > Why is bug 1028398 avoiding the Marketplace to use the FxA native flow in > 2.0 and how is situation different in 2.1? What we did in bug 1028398 is to > make sure that we ask for the FxA password (only) the first time a > non-preinstalled privileged app requests a FxA login. I believe the only > extra thing that the Marketplace needs to do after bug 1028398 is to add the > moz-firefox-accounts permission to its manifest. I'd have to call in the big guns of Sam Penrose and Allen Short for that, I'm going on what they told me :)
Flags: needinfo?(spenrose)
Flags: needinfo?(ashort)
Flags: needinfo?(amckay)
The limitation for 2.0 is that privileged apps can't use native FxA, it only became available in 2.1.
Flags: needinfo?(ashort)
AFAIK Firefox Hello for FxOS is using native FxA in 2.0 and bug 1028398 landed in 2.0 as well, so I still can't see the limitation.
Flags: needinfo?(ashort)
Depends on: 1131440
This is good news, I hadn't kept up with changes to 2.0. thanks :-) Fixed in bug 1131732
Flags: needinfo?(ashort)
Flags: needinfo?(spenrose)
See also bug 1131732, from what I gather the Trusted UI changes needed did not land until 2.1. Meaning we'd have a half native, half not native flow in the Marketplace and Payments. Investigating if that will work.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Whiteboard: [marketplace-transition]
You need to log in before you can comment on or make changes to this bug.