Closed
Bug 1129164
Opened 10 years ago
Closed 10 years ago
Disable failing mulet mochitests
Categories
(Firefox OS Graveyard :: Runtime, defect)
Tracking
(firefox38 fixed)
RESOLVED
FIXED
2.2 S6 (20feb)
Tracking | Status | |
---|---|---|
firefox38 | --- | fixed |
People
(Reporter: gwagner, Assigned: gerard-majax)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
gerard-majax
:
review+
|
Details | Diff | Splinter Review |
We want to unhide the test suite.
Reporter | ||
Comment 1•10 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=60a6a8b5cfd2
Reporter | ||
Comment 2•10 years ago
|
||
Reporter | ||
Updated•10 years ago
|
Attachment #8558761 -
Flags: review?(mrbkap)
Attachment #8558761 -
Flags: review?(bent.mozilla)
Reporter | ||
Updated•10 years ago
|
Blocks: firefox-mulet
Comment on attachment 8558761 [details] [diff] [review] 1129164.diff Review of attachment 8558761 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/workers/test/mochitest.ini @@ +169,5 @@ > [test_url.html] > [test_urlApi.html] > [test_workersDisabled.html] > [test_worker_interfaces.html] > +skip-if = buildapp == 'mulet' This one is too important to just disable. We need to figure out what mulet is giving for these values and fix it to think b2g == true on mulet: http://mxr.mozilla.org/mozilla-central/source/dom/workers/test/test_worker_interfaces.js?force=1#174 Then it should all work.
Attachment #8558761 -
Flags: review?(bent.mozilla) → review-
Updated•10 years ago
|
Attachment #8558761 -
Flags: review?(mrbkap)
Assignee | ||
Comment 4•10 years ago
|
||
Given bug 1129849 and its dependencies, we should be good to update this path to remove the disabling of worker_interfaces and get green after this. The remaining errors I see on mochitest 4 for Mulet on https://treeherder.mozilla.org/#/jobs?repo=try&revision=20fcc0c2a17b&exclusion_profile=false are the tests skipped in this patch.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → lissyx+mozillians
Assignee | ||
Comment 5•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8558761 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Attachment #8563390 -
Flags: review?(bent.mozilla)
Assignee | ||
Comment 6•10 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d62c5e7ffbc6
Comment on attachment 8563390 [details] [diff] [review] Disable some failing mochitests on mulet r=bent Review of attachment 8563390 [details] [diff] [review]: ----------------------------------------------------------------- Ok, the patch is broken, but r+ with it fixed: ::: embedding/test/mochitest.ini @@ +8,5 @@ > [test_nsFind.html] > [test_private_window_from_content.html] > # Next two tests are disabled in e10s because of bug 989501. > [test_window_open_position_constraint.html] > +skip-if = toolkit == 'android' || e10s || 'mulet' Hm, this looks wrong. Won't this disable everywhere since 'mulet' will evaluate to True? You want |buildapp == 'mulet'|
Attachment #8563390 -
Flags: review?(bent.mozilla) → review+
Assignee | ||
Comment 8•10 years ago
|
||
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8563949 [details] [diff] [review] Disable some failing mochitests on mulet r=bent Carrying r+
Attachment #8563949 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Attachment #8563390 -
Attachment is obsolete: true
Assignee | ||
Comment 10•10 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0bb7e101133b
Assignee | ||
Comment 11•10 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d144b06dbabc
Assignee | ||
Comment 12•10 years ago
|
||
(In reply to Alexandre LISSY :gerard-majax from comment #11) > https://treeherder.mozilla.org/#/jobs?repo=try&revision=d144b06dbabc Green for mulet mochitests 1, 2, 3, 4, and 5 \o/
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 13•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/4af25f297091
Keywords: checkin-needed
Reporter | ||
Updated•10 years ago
|
Whiteboard: [systemsfe]
Target Milestone: --- → 2.2 S6 (20feb)
You need to log in
before you can comment on or make changes to this bug.
Description
•