:gerard-majax [PTO 01/08/2023-10/09/2023] Reporter
	Description • 11 years ago

We want to do strange things: building Firefox with MOZ_B2G. Calling it Mulet, since I can't remember this very nice swedish name proposed by jonas :(

	:gerard-majax [PTO 01/08/2023-10/09/2023] Reporter
	Comment 1 • 11 years ago

I could build it as a new product based on a merge of browser and b2g. Launching the resulting binary worked, though some issue with browser.xul not being at the correct place lead to a couple of days of head scratching to get a UI. Thanks to :ochameau I got the correct lead and checking to find out what was wrong.

I suspect some other components were missing, since after the UI correctly showed up, close to nothing was working: opening preferences did work, but any browsing was not even triggering anything ; js console did not showed, etc.

After discussing with :ochameau and :vingtetun, I will pursue this with only hacking inside the browser product.

	[:fabrice] Fabrice Desré
	Comment 2 • 11 years ago

(In reply to Alexandre LISSY :gerard-majax from comment #1)
> 
> After discussing with :ochameau and :vingtetun, I will pursue this with only
> hacking inside the browser product.

What's the rationale for doing that?
I think we rather need a new 'mulet' product that will mostly do build system magic to get some pieces from browser/ and some from b2g/.

	Alexandre Poirot [:ochameau] Assignee
	Comment 3 • 11 years ago

(In reply to Fabrice Desré [:fabrice] from comment #2)
> (In reply to Alexandre LISSY :gerard-majax from comment #1)
> > 
> > After discussing with :ochameau and :vingtetun, I will pursue this with only
> > hacking inside the browser product.
> 
> What's the rationale for doing that?
> I think we rather need a new 'mulet' product that will mostly do build
> system magic to get some pieces from browser/ and some from b2g/.

Creating a new product that would be able to build Firefox correctly sounds like a lot of work with various copy paste of manifests/makefiles. We really want everything that is currently shipped in Firefox. It sounds really easy to miss preferences and pieces coming from anywhere in the m-c repo!
Whereas if we just add optional extensions during firefox product, we just have to add some ifdef here and there. But my _mozilla_ build system knowledges being close to zero, I may not be aware of tricks to get a kind of alias 'mulet' product that would just build the 'firefox' product as-is plus some additional b2g things.
Build system tips are welcomed!

	Alexandre Poirot [:ochameau] Assignee
	Comment 4 • 11 years ago

Depends on bug 874984 as xul scrollbars are broken due to content.css being applied also to firefox chrome elements.

	Alexandre Poirot [:ochameau] Assignee
	Comment 5 • 11 years ago

console.log not working in all apps but the system app.

	Alexandre Poirot [:ochameau] Assignee
	Comment 6 • 11 years ago

Morphing this bug to a meta bug to track all necessary work to make b2g work seemleslly into Firefox.
So moving build-related work into bug 961745.

	Alexandre Poirot [:ochameau] Assignee
	Comment 7 • 11 years ago

Here is a branch of most of dependent bugs (with some bonuses, like simulator merge with b2g desktop):
https://github.com/ochameau/mozilla-central/tree/mulet

With this branch you get a working mulet. Firefox is still bad looking, but most of everything works.
At least gaia start, you can launch apps and the few I tried were working.

The main issues are the brute disabling of reuseGlobal pref that completely broke firefox (bug 961777),
and crashes on startup if the camera app is installed.

Here is the current steps to test it:
$ git remote add ochameau git@github.com:ochameau/mozilla-central.git
$ git fetch ochameau
$ git checkout ochameau/mulet
$ mach build
$ ./obj/dist/bin/firefox-bin -profile ~/gaia/profile -chrome chrome://browser/content/browser.xul
-- enable responsive mode
-- turn touch event mode on
-- open chrome://b2g/content/shell.html in a tab

	Alexandre Poirot [:ochameau] Assignee
	Comment 8 • 11 years ago

New changesets, simplifying b2g start:
https://github.com/ochameau/mozilla-central/tree/mulet

$ mach build
$ ./obj/dist/bin/firefox-bin -profile ~/gaia/profile
-- Now b2g should be automatically opened in a tab, with responsive mode, touch events and devtools.

Note that, for now, it only work with non-debug, non-desktop gaia profile
(i.e. DESKTOP=1/DEBUG=1 will make it fail)

Also, the crashes related to the camera app only occurs with debug builds.

	Alexandre Poirot [:ochameau] Assignee
	Comment 9 • 11 years ago

No luck with the crash, but bug 963239 is going to address a whole bunch of breakages.

I pushed a rebased version of the branch on github with all patches from all dependent bugs.

	Alexandre Poirot [:ochameau] Assignee
	Comment 10 • 11 years ago

I push to the git branch quite often, after rebasing on recent master:
  https://github.com/ochameau/mozilla-central/tree/mulet

The mulet works quite well from a user perspective.

	Axel Hecht [:Pike]
	Comment 11 • 11 years ago

(In reply to Alexandre Poirot (:ochameau) from comment #10)
> I push to the git branch quite often, after rebasing on recent master:
>   https://github.com/ochameau/mozilla-central/tree/mulet
> 
> The mulet works quite well from a user perspective.

Can you rework that to be a clone of https://github.com/mozilla/gecko-dev ? It seems that your master is based on the old hashes, but not necessarily your mulet branch?

	Alexandre Poirot [:ochameau] Assignee
	Comment 12 • 11 years ago

(In reply to Axel Hecht [:Pike] from comment #11)
> Can you rework that to be a clone of https://github.com/mozilla/gecko-dev ?
> It seems that your master is based on the old hashes, but not necessarily
> your mulet branch?

We are planning to spawn a project branch for the mulet.
Let's do that.

Gregor, can you help setting up such branch?

	Alexandre Poirot [:ochameau] Assignee
	Comment 13 • 11 years ago

Let's see how it looks on mac and windows:
  https://tbpl.mozilla.org/?tree=Try&rev=73f969823c87

	Chris Mills [:cmills]
	Comment 14 • 10 years ago

Looking forward to testing this out. I'll keep monitoring this for MDN-docs readiness.

	Alexandre Poirot [:ochameau] Assignee
	Comment 15 • 10 years ago

Significant step reached: Mulet is running all xpcshell/mochitest (with just a few blacklisted):
  https://tbpl.mozilla.org/?tree=Try&rev=50519e76486e

	Alexandre Poirot [:ochameau] Assignee
	Comment 16 • 10 years ago

Another try with rebased patch queue + some new changesets:
  https://tbpl.mozilla.org/?tree=Try&rev=b620c9971a60
Tests are still green (still with a mulet specific blacklist that looks quite small)

	Alexandre Poirot [:ochameau] Assignee
	Comment 17 • 10 years ago

New set of patches on mulet:
  https://github.com/ochameau/mozilla-central/tree/mulet
Still mostly green:
  https://tbpl.mozilla.org/?tree=Try&rev=15087eb5ff49

Fixed:
- app install from marketplace,
- permission prompts,
- performance issue,
- integrates gaia helpers into responsive UI.