Closed
Bug 1132257
Opened 10 years ago
Closed 10 years ago
Update cubeb from upstream
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla38
| Tracking | Status | |
|---|---|---|
| firefox38 | --- | fixed |
People
(Reporter: kinetik, Assigned: kinetik)
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
padenot
:
review+
|
Details | Diff | Splinter Review |
Mostly just formatting changes, but I have taken dmajor's patch from bug 1131871 a step further and (re-)added error checking to COM initialization. It's a fairly simple change, but it needs a proper review.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8563094 -
Flags: review?(padenot)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Small refresh to pick up cpeterson's warning fixes and a minor state clearing bug in WASAPI.
Attachment #8564791 -
Flags: review?(padenot)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8563094 -
Attachment is obsolete: true
Attachment #8563094 -
Flags: review?(padenot)
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
||
Comment 4•10 years ago
|
||
20:50:31 INFO - COM already initialized in STA.
20:50:31 INFO - 1923 INFO TEST-UNEXPECTED-FAIL | dom/media/webaudio/test/test_maxChannelCount.html | We can query the maximum number of channels - expected PASS
|
|
Assignee | |
Comment 5•10 years ago
|
||
|
|
Assignee | |
Comment 6•10 years ago
|
||
Don't treat COM concurrency model change as an error; fixes timeout in test.
Also adds some error handling around render thread shutdown, and makes the debug logging threadsafe by writing only a single line.
Attachment #8565194 -
Flags: review?(padenot)
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8564791 -
Attachment is obsolete: true
Attachment #8564791 -
Flags: review?(padenot)
|
|
||
Updated•10 years ago
|
Attachment #8565194 -
Flags: review?(padenot) → review+
|
|
Assignee | |
Comment 7•10 years ago
|
||
|
||
Comment 8•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•