We have too many allocator wrappers.

Comment on attachment 8566887 [details] [diff] [review] Remove nsMemory::Alloc/Free/Realloc Ah, I reordered my patch queue, and forgot to s/free/moz_free/ in this patch.

Comment on attachment 8566901 [details] [diff] [review] Remove nsMemory::Alloc/Free/Realloc This patch reordering thing was a mistake. This really all needs to go on top of mozalloc being merged in mozglue.

Comment on attachment 8584192 [details] [diff] [review] Use moz_xmalloc/moz_xrealloc/free instead of nsMemory::Alloc/Realloc/Free Review of attachment 8584192 [details] [diff] [review]: ----------------------------------------------------------------- We should really be using new/delete/smart pointers for some of these. :( (Not your problem.) Thank you for fixing the comments as well.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e60e056a230c https://hg.mozilla.org/integration/mozilla-inbound/rev/da6cbd725f5f

At least this needs some update: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIMemory Like with bug 1138293. I want to discuss how best to update the doc(s).

https://hg.mozilla.org/mozilla-central/rev/e60e056a230c https://hg.mozilla.org/mozilla-central/rev/da6cbd725f5f