Closed
Bug 1134920
Opened 10 years ago
Closed 10 years ago
Remove nsMemory::Alloc/Free/Realloc
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
(Keywords: dev-doc-needed)
Attachments
(2 files, 2 obsolete files)
(deleted),
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
We have too many allocator wrappers.
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8566887 [details] [diff] [review] Remove nsMemory::Alloc/Free/Realloc Ah, I reordered my patch queue, and forgot to s/free/moz_free/ in this patch.
Attachment #8566887 -
Flags: review?(nfroyd)
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8566887 -
Attachment is obsolete: true
Attachment #8566901 -
Flags: review?(nfroyd)
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8566901 [details] [diff] [review] Remove nsMemory::Alloc/Free/Realloc This patch reordering thing was a mistake. This really all needs to go on top of mozalloc being merged in mozglue.
Attachment #8566901 -
Flags: review?(nfroyd)
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8566901 -
Attachment is obsolete: true
Attachment #8584192 -
Flags: review?(nfroyd)
Comment 7•10 years ago
|
||
Comment on attachment 8584192 [details] [diff] [review] Use moz_xmalloc/moz_xrealloc/free instead of nsMemory::Alloc/Realloc/Free Review of attachment 8584192 [details] [diff] [review]: ----------------------------------------------------------------- We should really be using new/delete/smart pointers for some of these. :( (Not your problem.) Thank you for fixing the comments as well.
Attachment #8584192 -
Flags: review?(nfroyd) → review+
Updated•10 years ago
|
Attachment #8584193 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e60e056a230c https://hg.mozilla.org/integration/mozilla-inbound/rev/da6cbd725f5f
Assignee | ||
Comment 9•10 years ago
|
||
At least this needs some update: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIMemory Like with bug 1138293. I want to discuss how best to update the doc(s).
Keywords: dev-doc-needed
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e60e056a230c https://hg.mozilla.org/mozilla-central/rev/da6cbd725f5f
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•