Closed Bug 1134968 Opened 10 years ago Closed 10 years ago

JS_NewObjectWithGivenProto will happily create null-parent objects if you pass in a null proto

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla39
Tracking Flags:
Tracking Status
firefox39 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

If JS_NewObjectWithGivenProto is passed a null parent and null proto, use the context's current global as the parent
(deleted), patch
Waldo
: review+
Details | Diff | Splinter Review
Unlike JS_NewObject, which will default null parent to the global, JS_NewObjectWithGivenProto defaults it to the parent of the proto, if there is a proto. If not, it leaves it null. We should probably default it to the global instead.
Attachment #8566960 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/5dabb5e547e8
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Blocks: 1136925
Depends on: 1142731
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: