Closed
Bug 1142731
Opened 10 years ago
Closed 10 years ago
Fix IsInternalFunctionObject to work correctly again
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
I believe I broke it in bug 1134968: after that the parent is never null for functions created via the NewFunction APIs, afaict.
|
Assignee | |
Comment 1•10 years ago
|
||
[Tracking Requested - why for this release]: This might expose to script objects that must never be exposed.
tracking-firefox39:
--- → ?
Keywords: regression
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8576909 -
Flags: review?(jwalden+bmo)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
|
||
Updated•10 years ago
|
Attachment #8576909 -
Flags: review?(jwalden+bmo) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/79f4ecda07ca and then https://hg.mozilla.org/integration/mozilla-inbound/rev/e7a3117249ee to fix the bustage due to asmjs lambdas.
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/79f4ecda07ca
https://hg.mozilla.org/mozilla-central/rev/e7a3117249ee
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Since this is already fixed I don't think I need to track it.
tracking-firefox39:
? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•