Closed
Bug 1136206
Opened 10 years ago
Closed 10 years ago
Send build notifications to a notification specific list instead of r-d
Categories
(Release Engineering :: Release Automation: Other, defect)
Release Engineering
Release Automation: Other
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: lmandel, Assigned: bhearsum)
Details
Attachments
(7 files)
(deleted),
patch
|
rail
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
rail
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
rail
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Sylvestre
:
review+
rail
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
rail
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
rail
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
rail
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
I'd like to get the build notifications off of r-d and onto a separate notification specific mailing list as several people have told me that they do not need these notifications and they add a lot of noise to the r-d list.
I'm not tied to any specific name for the list but can suggest something like build-notifications@.
As this is a trivial change, I would prefer to make the change on Friday this week. I would like to announce the change today/tomorrow so that people have a couple of days to self subscribe to the new list before we cut over.
Assignee | ||
Comment 1•10 years ago
|
||
I was under the impression that you were creating the list, or that it was already created. Switching the notifications to the new list is trivial, I don't know about creating the new list - I've never done that before.
Reporter | ||
Comment 2•10 years ago
|
||
I can create a new list. Any preference on the name?
Reporter | ||
Comment 3•10 years ago
|
||
I created the list release-automation-notifications@mozilla.com based on nthomas' suggestion. Please use this list for the notifications.
https://groups.google.com/a/mozilla.com/d/forum/release-automation-notifications
Reporter | ||
Comment 4•10 years ago
|
||
Ben - Can you configure notifications to go to the new list by Friday (Feb 27), at which point I'd like to discontinue sending the notifications to r-d.
Flags: needinfo?(bhearsum)
Assignee | ||
Comment 5•10 years ago
|
||
This should switch everything except the "Build of Foo" mails, which I think we said should stay on release-drivers...
Flags: needinfo?(bhearsum)
Attachment #8569212 -
Flags: review?(rail)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → bhearsum
Updated•10 years ago
|
Attachment #8569212 -
Flags: review?(rail) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8569212 [details] [diff] [review]
switch to new list
I landed this to default and production. All new release mail will go to release-automation-notifications@mozilla.com instead of release-drivers@mozilla.org.
Attachment #8569212 -
Flags: checked-in+
Assignee | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 7•10 years ago
|
||
Assignee | ||
Comment 8•10 years ago
|
||
Of course, this isn't as simple as it seems. The "Build of XXXXXX" mail also went to the list, but we need it to go to release-drivers@mozilla.org. The simplest way of fixing this would be to make it the only thing that importantRecipients get. Except that's difficult because then Thunderbird releases would not send all of the necessary mail to thunderbird-drivers@mozilla.org. We could add thunderbird-drivers to allRecipients, as long as they're willing to get the full onslaught of release mail instead of just the "important" stuff.
Another way to fix this would be to put an e-mail address in release runner's ini file to send the "Build of XXXXX" mail to. Except if we do that, we can't send Thunderbird and Firefox "Build of XXXXX" mail to different places.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 9•10 years ago
|
||
The only sensible solution here seems to be to send thunderbird-drivers all the mail. I mailed them to warn them of this, and this patch + the incoming release config will disable all automation mail to importantRecipients, and send ALL of the mail to the new list for Firefox, and thunderbird-drivers for Thunderbird.
Attachment #8569425 -
Flags: review?(rail)
Assignee | ||
Comment 10•10 years ago
|
||
Attachment #8569429 -
Flags: review?(rail)
Updated•10 years ago
|
Attachment #8569429 -
Flags: review?(rail) → review+
Comment 11•10 years ago
|
||
Comment on attachment 8569425 [details] [diff] [review]
don't send any mail to importantRecipients during automation
yay, lesscode++
Attachment #8569425 -
Flags: review?(rail) → review+
Assignee | ||
Updated•10 years ago
|
Attachment #8569425 -
Flags: checked-in+
Assignee | ||
Comment 12•10 years ago
|
||
Comment on attachment 8569429 [details] [diff] [review]
adjust recipients
Leaving this bug open for now to avoid jinxing myself again...
Attachment #8569429 -
Flags: checked-in+
Assignee | ||
Comment 13•10 years ago
|
||
There's a couple bits of weirdness that we hit with 37.0b2:
1) I messed up importantRecipients in a few release config files (but not templates)
2) release runner uses the OLD release config to find some details, such as importantRecipients, because it sends mail prior to bumping.
The combination of these two things lead to the "Build of XXXXXXX" mails going to the new list rather than release-drivers. This should mostly fix itself, but I want to fix #2 to avoid confusion in the future.
Assignee | ||
Comment 14•10 years ago
|
||
Sylvestre, I think sending mail here is the right thing to do. It still gets sent prior to release sanity (which is the cause of most failures), but it lets us use the already bumped release config to make sure we use the correct recipients.
Attachment #8571968 -
Flags: review?(sledru)
Attachment #8571968 -
Flags: review?(rail)
Assignee | ||
Comment 15•10 years ago
|
||
Probably not necessary...but just in case the other patch doesn't land before the next releases start.
Attachment #8571969 -
Flags: review?(rail)
Comment 16•10 years ago
|
||
Comment on attachment 8571968 [details] [diff] [review]
send "Build of XXXXX' mail after bumping config
As you confirmed on irc that the "Writing configs" is fast and safe, this change works for me!
Attachment #8571968 -
Flags: review?(sledru) → review+
Updated•10 years ago
|
Attachment #8571969 -
Flags: review?(rail) → review+
Updated•10 years ago
|
Attachment #8571968 -
Flags: review?(rail) → review+
Assignee | ||
Comment 17•10 years ago
|
||
Comment on attachment 8571968 [details] [diff] [review]
send "Build of XXXXX' mail after bumping config
Landed this and restarted releaserunner to pick up the change.
Attachment #8571968 -
Flags: checked-in+
Assignee | ||
Updated•10 years ago
|
Attachment #8571969 -
Flags: checked-in+
Comment 18•10 years ago
|
||
Assignee | ||
Comment 19•10 years ago
|
||
I had to land a couple of bustage fixes for my release-runner.py change: https://hg.mozilla.org/build/tools/rev/69b6d63cc878 and https://hg.mozilla.org/build/tools/rev/3e792b219da6
Assignee | ||
Comment 20•10 years ago
|
||
I think everything is going where it's expected now. Lawrence, how does it look for you?
Flags: needinfo?(lmandel)
Reporter | ||
Comment 21•10 years ago
|
||
I see the 36.0.1 build notifications on r-d (even with the [desktop] and [mobile] topics!) and the rest of the build notification on the new list. Looks good to me.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Flags: needinfo?(lmandel)
Resolution: --- → FIXED
Assignee | ||
Comment 22•10 years ago
|
||
Last one (hopefully): release runner failure mails, which are controlled by its config. In retrospect, I don't know why we don't use this to send the "Build of XXXXXX" mail.
Attachment #8573242 -
Flags: review?(rail)
Updated•10 years ago
|
Attachment #8573242 -
Flags: review?(rail) → review+
Assignee | ||
Updated•10 years ago
|
Attachment #8573242 -
Flags: checked-in+
Assignee | ||
Comment 23•10 years ago
|
||
I warned release@ and qa-drivers@ that they needed to sign up for the list last week, time to make the change. This also moves Thunderbird mail to the new list, which probably should've been done before.
Attachment #8575296 -
Flags: review?(rail)
Updated•10 years ago
|
Attachment #8575296 -
Flags: review?(rail) → review+
Assignee | ||
Updated•10 years ago
|
Attachment #8575296 -
Flags: checked-in+
Comment 24•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•