Closed
Bug 1136738
Opened 10 years ago
Closed 10 years ago
Treeherder: Improve error messages when authentication is required but the user is not logged in
Categories
(Tree Management :: Treeherder: API, defect, P2)
Tree Management
Treeherder: API
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jlal, Assigned: jlal)
References
Details
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1113281 +++
Discussed /w Ed on IRC short version is on 401 we add an error message like this:
Error: Please login to Treeherder using Persona to complete this action
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → jlal
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•10 years ago
|
||
Please take careful look over the new file too I am not sure if this also needs to be included elsewhere or perhaps some other config is needed.
Attachment #8569284 -
Flags: review?(cdawson)
|
||
Updated•10 years ago
|
Priority: -- → P2
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8569284 [details]
https://github.com/mozilla/treeherder-ui/pull/387/files
Interestingly, with the PR link containing the ``/files`` part, it doesn't link
straight to github, I have to copy and paste. Not that big, but figured I'd mention it.
Looks good!
Attachment #8569284 -
Flags: review?(cdawson) → review+
|
||
Comment 4•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder-ui
https://github.com/mozilla/treeherder-ui/commit/39992a7d81e130414bd2307e648360ef6d3fde5f
Bug 1136738 - Add better error messages when server fails due to auth errors r=camd
https://github.com/mozilla/treeherder-ui/commit/ff83752c9df8d6676714215308614b7f56f16e5d
Merge pull request #387 from lightsofapollo/bug-1136738
Bug 1136738 - Add better error messages when server fails due to auth er...
|
|
Assignee | |
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/47ae41484d4eb23d719ee09a9d854b931cb392d8
Bug 1136738 - Add better error messages when server fails due to auth errors r=camd
https://github.com/mozilla/treeherder/commit/a0f820bcca9eb982e730a25a0a31b8ab51c13275
Merge pull request #387 from lightsofapollo/bug-1136738
Bug 1136738 - Add better error messages when server fails due to auth er...
You need to log in
before you can comment on or make changes to this bug.
Description
•