Closed Bug 1137890 (containerless-scrolling) Opened 10 years ago Closed 6 years ago

Ship containerless scrolling on Android

Categories

(Core :: Panning and Zooming, defect, P3)

Product:
Core
Component:
Panning and Zooming
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: kats, Assigned: botond)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Bug 1137890 - Let containerless scrolling ride the trains. r=kats
(deleted), text/x-phabricator-request
Details
+++ This bug was initially created as a clone of Bug #1123921 +++ Bug 1123921 turned it on for desktop, but we should turn it on everywhere and then get rid of the pref.
Er.. that try push was not what I meant to do. Here's a better one: https://treeherder.mozilla.org/#/jobs?repo=try&revision=42c31f4f25a2
On Fennec if I enable the layout.scroll.root-frame-containers pref it looks like the root layer (the one corresponding to the XUL window) does still get a metrics. Furthermore whereas before the metrics had scrollId=0 and was being ignored, it now gets scrollId > 0 and so the compositor ends up putting the shadow transform on that layer rather than the actual content. I suspect the code in nsDisplayList::PaintRoot needs to be adjusted to fix this, trying that out now.
Attached patch Patch for fennec (obsolete) (deleted) — — Splinter Review
This fixes the obviously-wrong behaviour on my local build. Not sure if it will fix the tests but I'll push to try and see.
Attached patch Patch for fennec (obsolete) (deleted) — — Splinter Review
Slightly updated, so the pref takes precedence. Try push is at https://treeherder.mozilla.org/#/jobs?repo=try&revision=a91d24ddb98d
Attachment #8575554 - Attachment is obsolete: true
Looks like we can turn it on for B2G right away. Maybe we should do that!
Has anyone tested it on an actual device to make sure there aren't obvious problems?
I did some testing just now and everything seemed fine. Filed bug 1153589 with a patch to enable it on B2G.
Depends on: 1155025
Attachment #8575560 - Attachment is obsolete: true
Depends on: 1157066
Depends on: 1158392
Commandeering this bug to let containerless scrolling on Android ride the trains.
Component: Layout → Panning and Zooming
Priority: -- → P3
Summary: Turn on containerless scrolling for root scroll frames by default → Ship containerless scrolling on Android
Moving over bugs blocked by containerless scrolling from bug 1459312.
Blocks: android-rdl, desktop-zoom-xp, 1480261, 1489653, 1479757
Alias: containerless-scrolling
Blocks: 1523405
Depends on: 1527511
Depends on: 1527675
Depends on: 1533607
Assignee: nobody → botond
Blocks: 1534458

I discussed this with Jessie today, and we have a good feeling about letting this ride the 67 train.

If an unexpected serious regression does come up, we can flip the pref back off.

I'm going to go ahead and land this. The remaining open dependency, bug 1527511, is an edge case that can be uplifted post-merge.

Pushed by bballo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/007b5a2e825a Let containerless scrolling ride the trains. r=kats

https://hg.mozilla.org/mozilla-central/rev/007b5a2e825a

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: