Closed
Bug 1153589
Opened 10 years ago
Closed 9 years ago
Turn on containerless scrolling for root scroll frames on B2G
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: kats, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1137890 +++
+++ This bug was initially created as a clone of Bug #1123921 +++
Try run in bug 1137890 shows that enabling containerless-root on B2G passes all tests. Local testing also showed no strange/broken behaviour, so I think we're good to turn it on.
Attachment #8591280 -
Flags: review?(tnikkel)
Comment 1•10 years ago
|
||
Comment on attachment 8591280 [details] [diff] [review]
Patch
Ship it!
Attachment #8591280 -
Flags: review?(tnikkel) → review+
Reporter | ||
Comment 2•10 years ago
|
||
Comment on attachment 8591280 [details] [diff] [review]
Patch
My bad, I tested this more and realized it does actually break behaviour in the browser for some pages (e.g. people.mozilla.com/~kgupta/grid.html) when zoomed.
Attachment #8591280 -
Flags: review+ → review-
Reporter | ||
Comment 3•10 years ago
|
||
The clipping change from bug 1147038 does fix half of the problem I was seeing, but the scrollbars are still mispositioned. Hopefully fixing bug 1133905 will take care of this.
Comment 4•10 years ago
|
||
Comment on attachment 8591280 [details] [diff] [review]
Patch
This should be good now.
Attachment #8591280 -
Flags: review- → review+
Comment 5•10 years ago
|
||
Comment 7•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Comment 8•10 years ago
|
||
This is causing a smoke test blocker. Please see bug 1166326. We may need this backed out.
QA Whiteboard: [QAnalyst-Triage+]
Whiteboard: [backout-asap]
Comment 9•10 years ago
|
||
Backed out in
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7e537fd67ec
The sheriff assured me this would make the next nightly.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [backout-asap]
Comment 10•9 years ago
|
||
Comment 11•9 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 10 years ago → 9 years ago
Resolution: --- → FIXED
Comment 12•9 years ago
|
||
This seems to cause the regression to youtube video app's video playback. When I scroll the youtube video app's list during video playback, video's rendering position is not correct.
Comment 13•9 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #12)
> This seems to cause the regression to youtube video app's video playback.
> When I scroll the youtube video app's list during video playback, video's
> rendering position is not correct.
I am going to check it by local back-out.
Comment 14•9 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #12)
> This seems to cause the regression to youtube video app's video playback.
> When I scroll the youtube video app's list during video playback, video's
> rendering position is not correct.
mstange said that bug 1148582 seems to fix it.
Comment 15•9 years ago
|
||
This is the "clip not moving with async scroll" issue. I haven't checked which patches in bug 1148582 will actually fix it, I just know that we're expecting that bug to take care of all our clipping problems.
Comment 16•9 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #13)
> (In reply to Sotaro Ikeda [:sotaro] from comment #12)
> > This seems to cause the regression to youtube video app's video playback.
> > When I scroll the youtube video app's list during video playback, video's
> > rendering position is not correct.
>
> I am going to check it by local back-out.
The local back-out fixed the problem.
Comment 17•9 years ago
|
||
(In reply to Sotaro Ikeda [:sotaro] from comment #12)
> This seems to cause the regression to youtube video app's video playback.
> When I scroll the youtube video app's list during video playback, video's
> rendering position is not correct.
kats, is it expected regression until bug 1148582 fix?
Flags: needinfo?(bugmail.mozilla)
Reporter | ||
Comment 18•9 years ago
|
||
Redirecting to tn, since he's the one actually working on this.
Flags: needinfo?(bugmail.mozilla) → needinfo?(tnikkel)
Comment 19•9 years ago
|
||
The landing for this is causing a smoke test blocker. Please see bug 1170611. We may need this backed out.
Whiteboard: [backout-asap]
Comment 20•9 years ago
|
||
Status: RESOLVED → REOPENED
Flags: needinfo?(tnikkel)
Resolution: FIXED → ---
Comment 21•9 years ago
|
||
(In reply to Markus Stange [:mstange] from comment #15)
> This is the "clip not moving with async scroll" issue. I haven't checked
> which patches in bug 1148582 will actually fix it, I just know that we're
> expecting that bug to take care of all our clipping problems.
It doesn't appear to be related to bug 1148582. There is only one actively scrolling scrollframe involved, and only one set of metrics.
Comment 22•9 years ago
|
||
(In reply to Timothy Nikkel (:tn) from comment #21)
> There is only one actively
> scrolling scrollframe involved, and only one set of metrics.
But two clips: The video ImageLayer has its own overflow:hidden clip, and then there is the clip of the actively scrolling scrollframe - during scrolling, we want to move the overflow:hidden clip but not the clip that clips the video to the scrollframe.
Comment 23•9 years ago
|
||
Oh right, forgot about non-scrolling clips.
Whiteboard: [backout-asap]
Comment 24•9 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•