Kartikaya Gupta (email:kats@mozilla.staktrace.com) Reporter
	Description • 9 years ago

+++ This bug was initially created as a clone of Bug #1137890 +++

+++ This bug was initially created as a clone of Bug #1123921 +++

Try run in bug 1137890 shows that enabling containerless-root on B2G passes all tests. Local testing also showed no strange/broken behaviour, so I think we're good to turn it on.

	Timothy Nikkel (:tnikkel)
	Comment 1 • 9 years ago

Comment on attachment 8591280 [details] [diff] [review]
Patch

Ship it!

	Kartikaya Gupta (email:kats@mozilla.staktrace.com) Reporter
	Comment 2 • 9 years ago

Comment on attachment 8591280 [details] [diff] [review]
Patch

My bad, I tested this more and realized it does actually break behaviour in the browser for some pages (e.g. people.mozilla.com/~kgupta/grid.html) when zoomed.

	Kartikaya Gupta (email:kats@mozilla.staktrace.com) Reporter
	Comment 3 • 9 years ago

The clipping change from bug 1147038 does fix half of the problem I was seeing, but the scrollbars are still mispositioned. Hopefully fixing bug 1133905 will take care of this.

	Timothy Nikkel (:tnikkel)
	Comment 4 • 9 years ago

Comment on attachment 8591280 [details] [diff] [review]
Patch

This should be good now.

	Timothy Nikkel (:tnikkel)
	Comment 5 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a27f48c8fa1

	Pulsebot
	Comment 6 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/b769ef24faed

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/b769ef24faed

	KTucker [:KTucker][Inactive 3/4/2016]
	Comment 8 • 9 years ago

This is causing a smoke test blocker. Please see bug 1166326. We may need this backed out.

	Timothy Nikkel (:tnikkel)
	Comment 9 • 9 years ago

Backed out in
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7e537fd67ec

The sheriff assured me this would make the next nightly.

	Pulsebot
	Comment 10 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/4cb3a97de6ee

	Carsten Book [:Tomcat]
	Comment 11 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/4cb3a97de6ee

	Sotaro Ikeda [:sotaro]
	Comment 12 • 9 years ago

This seems to cause the regression to youtube video app's video playback. When I scroll the youtube video app's list during video playback, video's rendering position is not correct.

	Sotaro Ikeda [:sotaro]
	Comment 13 • 9 years ago

(In reply to Sotaro Ikeda [:sotaro] from comment #12)
> This seems to cause the regression to youtube video app's video playback.
> When I scroll the youtube video app's list during video playback, video's
> rendering position is not correct.

I am going to check it by local back-out.

	Sotaro Ikeda [:sotaro]
	Comment 14 • 9 years ago

(In reply to Sotaro Ikeda [:sotaro] from comment #12)
> This seems to cause the regression to youtube video app's video playback.
> When I scroll the youtube video app's list during video playback, video's
> rendering position is not correct.

mstange said that bug 1148582 seems to fix it.

	Markus Stange [:mstange]
	Comment 15 • 9 years ago

This is the "clip not moving with async scroll" issue. I haven't checked which patches in bug 1148582 will actually fix it, I just know that we're expecting that bug to take care of all our clipping problems.

	Sotaro Ikeda [:sotaro]
	Comment 16 • 9 years ago

(In reply to Sotaro Ikeda [:sotaro] from comment #13)
> (In reply to Sotaro Ikeda [:sotaro] from comment #12)
> > This seems to cause the regression to youtube video app's video playback.
> > When I scroll the youtube video app's list during video playback, video's
> > rendering position is not correct.
> 
> I am going to check it by local back-out.

The local back-out fixed the problem.

	Sotaro Ikeda [:sotaro]
	Comment 17 • 9 years ago

(In reply to Sotaro Ikeda [:sotaro] from comment #12)
> This seems to cause the regression to youtube video app's video playback.
> When I scroll the youtube video app's list during video playback, video's
> rendering position is not correct.

kats, is it expected regression until bug 1148582 fix?

	Kartikaya Gupta (email:kats@mozilla.staktrace.com) Reporter
	Comment 18 • 9 years ago

Redirecting to tn, since he's the one actually working on this.

	KTucker [:KTucker][Inactive 3/4/2016]
	Comment 19 • 9 years ago

The landing for this is causing a smoke test blocker. Please see bug 1170611. We may need this backed out.

	Timothy Nikkel (:tnikkel)
	Comment 20 • 9 years ago

Backed out in
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0515cb0cb5a

	Timothy Nikkel (:tnikkel)
	Comment 21 • 9 years ago

(In reply to Markus Stange [:mstange] from comment #15)
> This is the "clip not moving with async scroll" issue. I haven't checked
> which patches in bug 1148582 will actually fix it, I just know that we're
> expecting that bug to take care of all our clipping problems.

It doesn't appear to be related to bug 1148582. There is only one actively scrolling scrollframe involved, and only one set of metrics.

	Markus Stange [:mstange]
	Comment 22 • 9 years ago

(In reply to Timothy Nikkel (:tn) from comment #21)
> There is only one actively
> scrolling scrollframe involved, and only one set of metrics.

But two clips: The video ImageLayer has its own overflow:hidden clip, and then there is the clip of the actively scrolling scrollframe - during scrolling, we want to move the overflow:hidden clip but not the clip that clips the video to the scrollframe.

	Timothy Nikkel (:tnikkel)
	Comment 23 • 9 years ago

Oh right, forgot about non-scrolling clips.

	Pulsebot
	Comment 24 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc07aa95d2c9

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 25 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/dc07aa95d2c9