Closed Bug 1140640 Opened 10 years ago Closed 10 years ago

Make From header editable per-message

Categories

(SeaMonkey :: MailNews: Composition, enhancement)

Product:
SeaMonkey
Component:
MailNews: Composition
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.35 fixed, seamonkey2.36 fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.36
Tracking Flags:
Tracking Status
seamonkey2.35 --- fixed
seamonkey2.36 --- fixed

People

(Reporter: neil, Assigned: neil)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Basic patch
(deleted), patch
mnyromyr
: review+
iannbugzilla
: review+
stefanh
: feedback+
iannbugzilla
: approval-comm-aurora+
Details | Diff | Splinter Review
+++ This bug was initially created as a clone of Bug #87987 +++ The backend pieces landed in the above bug, so while they bikeshed over the UI, I'm filing a new bug for our UI.
Attached patch Basic patch (deleted) — — Splinter Review
This just makes the From field always editable. Josiah was having problems changing identity on the Mac, so if neither of you can test on a Mac then let me know so that I can ask for stefanh's feedback.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #8574214 - Flags: review?(mnyromyr)
Attachment #8574214 - Flags: review?(iann_bugzilla)
Comment on attachment 8574214 [details] [diff] [review] Basic patch Seems correct to me, I cannot test on a Mac though.
Attachment #8574214 - Flags: review?(iann_bugzilla) → review+
Attachment #8574214 - Flags: feedback?(stefanh)
Comment on attachment 8574214 [details] [diff] [review] Basic patch I can edit the from field :-)
Attachment #8574214 - Flags: feedback?(stefanh) → feedback+
Pushed comm-central changeset 424c564b65e3
Target Milestone: --- → seamonkey2.36
Comment on attachment 8574214 [details] [diff] [review] Basic patch [Approval Request Comment] Regression caused by (bug #): 87987 User impact if declined: Can't change identity when composing mail String changes made by this patch: None
Attachment #8574214 - Flags: approval-comm-aurora?
Attachment #8574214 - Flags: approval-comm-aurora? → approval-comm-aurora+
Pushed comm-aurora changeset 9c3f366c9961.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-seamonkey2.35: --- → fixed
status-seamonkey2.36: --- → fixed
Resolution: --- → FIXED
Comment on attachment 8574214 [details] [diff] [review] Basic patch post-mortem sign-off
Attachment #8574214 - Flags: review?(mnyromyr) → review+
Depends on: 1170002
Blocks: 1204216
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: