Closed Bug 114142 Opened 23 years ago Closed 23 years ago

Uniform Twisty and Click Behavior

Categories

(SeaMonkey :: Sidebar, enhancement, P2)

enhancement

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.0

People

(Reporter: jaimejr, Assigned: bugs)

References

()

Details

Attachments

(2 files)

This is a tracking bug for work needed for Uniform Twisty and Click Behavior. Estimate time for completion 2 days.
Blocks: 102472
Keywords: meta
Summary: Uniform Twisty and Click Behavior → Uniform Twisty and Click Behavior
->ben
Assignee: trudelle → ben
Keywords: meta
what's the priority and target for this one? are we still planning to get this in for MachV?
I'm going to hazard a guess and say that this has been fixed. twisties in sidebar trees now operate in a uniform, single click fashion (trees have been converted to outliners)
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla0.9.9
Er, I think I meant to close this as WORKSFORME.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago23 years ago
Resolution: --- → WORKSFORME
verified.
Status: RESOLVED → VERIFIED
Reopening, P2/0.9.9. PRD intent of this feature was to have all links in sidebar tabs appear and behave the same, which is to appear as links and load in the content area on single click. In particular, this means changing Bookmarks, History, Search Results and What's Related. Samir currently has the correct working behavior implemented for Search Results in his tree.
Status: VERIFIED → REOPENED
Priority: P3 → P2
Resolution: WORKSFORME → ---
Since twisties share the same behavior in sidebar, this bug and bug 20455 are the same. The only dependency of this bug is now bug 71661.
Attached patch patch to fix (deleted) — Splinter Review
ignore the dump, it has been removed.
*** Bug 76420 has been marked as a duplicate of this bug. ***
some tweaking needed, at least on Linux: 1: cursor is a hand all the time when inside history or bookmarks sidebar. Should be a cursor when over twisties? 2: History: clicking a link has no effect, other than obsuring the little vertical line to the left of it. 3: History: Using context menu "open" or "open in new window" has no effect 4: History: clicking twisty can fail to open. 5: History: Clicking "Today" (or similar) can fail to open, intermittently takes two clicks, and intermittently opens AND closes on one click. 6: History: Clicking a folder can fail to open. If it opens: The first single click on a "day" folder will open+close. Only a next click will leave folder open. 7: History: Copy link address, delete and select all are all perm disabled
I think the usability improvement gained by the single-click-indicating hand cursor is far outweighted by the usability lost by the blue and underlined text. I can barely read my history or bookmarks in the sidebar anymore now that they're all blue and underlined. We should do it like IE and only change color and underline on hover. I understand that isn't currently possible in outliner, so I think the part of the fix that changed the color and added the underline should be backed out.
Color and undeline was unusual at first, but after some minutes I liked it. Not least: It makes sense. It tells me "single-click here in order to load" Possible enhancement: If it used my prefs for link color *without* me having to set prefs to force usage of "my colors" on webpages.
Most i mentioned in comment 11 is fixed (fix for bug 126704) - testing with current CVS, Linux. Three remaining problems in history sidebar: -History items also load on right-click -Context menus on urls there are gone (only "unloadables" like folders have context menus) -History folders and headlines like "Today" must be double-clicked to open. (And then they open very reliably - no surprises. But wasn't the intent to have them open on single-click?)
I haven't seen this in latest sidebar, but have in previous revisions, so I agree with Blake. Blue underline is needed in page to indicate link, but in a list where all items are links I think it can easily be limited to hover. cc marlon for UE input.
I would like to give another argument to second Blake's and Peter's opinion: Lists consisting of blue underlined links look like unprofessional web page and give the feeling to cgo back to the early '90 design. (This is not the place to begin a flame pro/against gnu.org sites)
i agree with blake's comment #12.
I would like to add my weight against the constant blue underline. This is really heavy to read. Especially on high resolution screens. My preference goes to underlining on hover. With a black text becoming blue (and not blue becoming red as it is in "Whats Related") because black on white is easier to read than blue on white.
nsbeta1+
Keywords: nsbeta1nsbeta1+
We have a choice, we can either have constant blue hover feedback, or none at all. Outliner currently does not support differentiating between different rows other than on basis of selection. Implementing support for individual hover/active is nontrivial, 3-4d.
Can we get the hand cursor without the blue underline?
You can get the hand by using some CSS. object { cursor:hand; }
Attached patch remove the underline (deleted) — Splinter Review
this same patch applied to both classic and modern css files removes the underline and maintains the hand cursor.
Final aspects of this in mozilla source tree are included in the patch in 128815.
No longer blocks: 126748
Status: REOPENED → ASSIGNED
Depends on: 128815
Mass-moving remaining Nav team 0.99 bugs to 1.0.
Target Milestone: mozilla0.9.9 → mozilla1.0
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago23 years ago
Resolution: --- → FIXED
verified.
Status: RESOLVED → VERIFIED
I'm not so sure history is fixed, I cant even click with the hand in history pane on the twisty, it doesn't do anything. build 3-20-03 w2k. Is this the same or new bug? I have to right click on the text of it.. it sounds like the history twisty should be working.. but it doesn't do it on system. New profile too.. right click will bring up its context menu and open the folder.. 1) expand folder on click on twisty 2) open context menu on click on twisty History panel is the only panel that I see #1 doesn't work and right click does both #1 and #2. If this is suppose to be fixed by 128815, history still has this problem.
reopening,.. see last comment. looked at 71661, that seems about single or double click.. and looked at bug 128815.. as that probably has the patch for this bug.. but history twisty still does *not* have uniform behavior as I noted in comment #28.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
resolving as fixed, please open separate bugs for specific exceptions.
Status: REOPENED → RESOLVED
Closed: 23 years ago23 years ago
Resolution: --- → FIXED
Claudius can you verify this one. thanks..
QA Contact: sujay → claudius
marking VERIFIED. I believe bug 132682 should cover the history-specific twisty problem.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: