Closed Bug 1142231 Opened 10 years ago Closed 9 years ago

[build-promotion] Create SDK in each en-US build

Categories

(Release Engineering :: General, defect, P2)

Product:
Release Engineering
Component:
General
Platform:
x86
macOS
Type:
defect

Tracking

(firefox44 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: nthomas, Assigned: rail)

References

Details

Attachments

(1 file)

sdk.diff
(deleted), patch
nthomas
: review+
rail
: checked-in+
Details | Diff | Splinter Review
This is for a world where XULRunner as a deliverable is gone (bug 672509), and we do a 'make sdk' in the Firefox build. There are binaries and IDLs created at build time, so it makes sense to do this on every compile job rather than in a downstream job once a revision is blessed.
Bug 1137000 is adding support for moz-automation.
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1137000
No longer blocks: 1118796
Attached patch sdk.diff (deleted) — — Splinter Review
These are "distilled" from date, SDK-related changes.
Attachment #8676285 - Flags: review?(nthomas)
Assignee: nthomas → rail
Blocks: 1178282
Comment on attachment 8676285 [details] [diff] [review] sdk.diff MOZ_AUTOMATION_SDK is getting enabled twice, probably because the if block predates Ben's enabling of the SDK in release builds. I guess the current form may be useful if something else is sourcing these mozconfigs. I thnk that's unlikely, but please investigate and if not remove one of the lines.
Attachment #8676285 - Flags: review?(nthomas) → review+
https://hg.mozilla.org/mozilla-central/rev/8f65c9d0d2c6
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: