Closed
Bug 1142458
Opened 10 years ago
Closed 10 years ago
sccache should make MACOSX_DEPLOYMENT_TARGET part of the cache key
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(2 files)
(deleted),
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
As per bug 1142006, the MACOSX_DEPLOYMENT_TARGET environment variable can influence the result of compilation. As such, its value should be part of the cache key.
Comment 2•10 years ago
|
||
Comment on attachment 8576591 [details] [diff] [review] Make MACOSX_DEPLOYMENT_TARGET part of the cache key Looking at the ENVIRONMENT section of the gcc man page, there is also an IPHONEOS_DEPLOYMENT_TARGET - might want to preemptively add that one as well.
Attachment #8576591 -
Flags: review?(mshal) → review+
Comment 3•10 years ago
|
||
Gross. Could we stop using this as an environment variable and just use -mmacosx-version-min instead? They do the same thing. Presumably sccache would handle it on the commandline properly?
Assignee | ||
Comment 4•10 years ago
|
||
It would, but as a general purpose tool, the issue would still exist.
Updated•10 years ago
|
QA Contact: pmoore → mshal
Updated•10 years ago
|
Attachment #8592013 -
Flags: review?(mshal) → review+
Assignee | ||
Comment 6•10 years ago
|
||
https://github.com/glandium/sccache/commit/f2429b787a17df3708f23ee7093ad2fe99951c3a https://github.com/glandium/sccache/commit/1fd35f188468d42490349b264e87bf5c998e3292
Assignee | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•