Closed Bug 1143666 Opened 10 years ago Closed 10 years ago

Add a hotkey for retriggering jobs

Categories

(Tree Management :: Treeherder, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: RyanVM, Assigned: jfrench)

Details

Attachments

(1 file)

In the case of mass-retriggers, having to click the button repeatedly gets old in a hurry. While BuildAPI is great for buildbot jobs, Taskcluster doesn't have any sort of similar functionality that I'm aware of, so that limits us to what the Treeherder interface gives us. So I'd like to have a workflow of using the arrow keys to move between jobs and a hotkey I can hit quickly to retrigger the jobs.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
Priority: -- → P3
So I have this pretty much done. As discussed in channel, we are considering the following change: 'r' - retrigger job 'b' - add related bug (** was 'r') This means folks who are used to 'r' need to be made aware, so adding other sheriffs for agreement. If there's another shortcut key we'd prefer to use instead for retrigger which preserves 'r' for add-related-bug, let me know. The first day may be a bit painful during the transition to production, but ultimately if we think it's the right key we might as well do it before it becomes even more entrenched, I think.
Flags: needinfo?(wkocher)
Flags: needinfo?(jmaher)
Flags: needinfo?(jlal)
I am +1 to r :)
Flags: needinfo?(jlal)
Jmaher is fine with the change also.
Flags: needinfo?(jmaher)
Attached file treeherder-ui-PR#425 (deleted) —
Please see above PR for status and review.
Attachment #8578741 - Flags: review?(emorley)
Comment on attachment 8578741 [details] treeherder-ui-PR#425 r+ with the comment addressed :-)
Attachment #8578741 - Flags: review?(emorley) → review+
I've made the change, it's totally the right thing to do. I re-tested and it appears to be fine. I'll check in with Wes if he's around, before a merge.
I mailed Wes to let him know of the change. Marking fixed per above merge. Will verify on the next push to stage/prod.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: needinfo?(wkocher)
Resolution: --- → FIXED
Verified fixed on stage and prod.
Status: RESOLVED → VERIFIED
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/eea9be46a32c4e61257c714689c8496cca04b4b4 Bug 1143666 - Add a shortcut for retrigger job https://github.com/mozilla/treeherder/commit/8cc0f7d4629db49dd6e8a5f53b7285ecf2a5f50d Merge pull request #425 from tojonmz/retrigger-shortcut Bug 1143666 - Add a shortcut for retrigger job
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: