Hi! I am a new contributor and I would like to know if this bug is still to be fixed? Can I try working on it as my first bug?

Sushmita, you are welcome to work on this bug. See the user story in how to get started.

Hi, Is this bug being worked on? If not i'd like to take a crack on it.

It’s been a while since the last update from the person interested.
Please have a go (-:

Hi guys,

I'd like some pointers/comments on this. Just to be sure I am thinking in the right direction.

Looking at the code I have come up with the following idea.

First, adding the boolean to the method. And secondly, introducing a elif to catch the newly introduced parameter and start the application with a clean profile.

def restart(self, clean=False, eRestartNotSameProfile=False, in_app=False, callback=None):
...
                    self.cleanup()
                    reraise(exc, "Requested restart of the application was aborted", tb)
        elif eRestartNotSameProfile:
            self.delete_session()
            self.instance.restart(clean=True)
            self.raise_for_port(timeout=self.DEFAULT_STARTUP_TIMEOUT)
        else:
            self.delete_session()
            self.instance.restart(clean=clean)
...

This however does not take into effect what would happen if both eRestartNotSameProfile and in_app are True.

So I wouldn't add each of the restart/shutdown flags as separate kwargs for both the restart() and quit() methods. Instead do it like what _request_in_app_shutdown() has. That way we only have to implement it now, and won't have to change it later if other flags are wanted.

Only note that with the safe mode flag set, the JS code of Marionette (driver.js) has to call restartInSafeMode() instead of quit().

Hi,

I just posted this patch, its is no where near complete. I just want to get feedback on the thought process that I am on.

Sebastiaan, you created a new review in Phabricator instead of re-using the former one. Not sure what you did locally but make sure that the link to the Phabricator revision in the commit message will be kept before pushing it out. Thanks.

As part of our groups H2 goal to learn how the process works for contributing to mozilla-central, I would like to help out with this bug. Also will help with my goal of improving my Python coding skill. I will work through the docs of getting my mozilla-central environment up and running and will let you know if I have any questions.

Hey David, I was out last week. Given that your comment is 6 days old, I wonder if you hit some blockers in getting the tests run.

No reply from assignee. Moving the bug back into the free to choose bucket list.

Hello, can I work on this?

Yes, feel free to pick it up, and let us know when you have questions. Therefore you can also join us on Matrix in the #interop channel.

Renan, I'm very sorry for the late reply and that your review request for the patch totally got under the wire! I will make sure to have a look at it early next week when I'm back at work.

Actually I gave an advice within the Phabricator review. So are you still interested to continue on this bug?

Quick update here:

• The eRestartNotSameProfile flag doesn't exist anymore, and as such isn't needed.
• The eForceQuit flag is meanwhile handled by Marionette itself and is determined my evaluating the response when notifying the quit-application-requested observer. So I don't think that we should add a force flag to the Marionette client code.
• Safe Mode isn't handled by a flag but as separate option given that it restarts the browser via Services.startup.restartInSafeMode()
• The eSilently flag will be added over on bug 1726465 because it needs further updates to the Marionette code.
• If no flag gets passed in the code in driver.js will now have to automatically fallback to eAttemptQuit.

Depends on D134323

https://hg.mozilla.org/mozilla-central/rev/8179ad2048b2
https://hg.mozilla.org/mozilla-central/rev/d40a900e78d5

Moving bugs for Marionette client due to component changes.