Closed
Bug 1144938
Opened 10 years ago
Closed 10 years ago
Add NSIS 3.0b1 to Mozilla Build and remove NSIS 3.0a2
Categories
(Firefox Build System :: MozillaBuild, task)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
Since NSIS 3.0a2 hasn't been deployed to the build systems we are going to go with NSIS 3.0b1 on the build systems and Mozilla Build
Assignee | ||
Comment 1•10 years ago
|
||
bug 1144934 will add it to configure.in
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8579669 -
Flags: review?(ryanvm)
Comment 3•10 years ago
|
||
Comment on attachment 8579669 [details] [diff] [review]
patch
Review of attachment 8579669 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM with the one comment addressed. Have you tested this locally or did you want me to give it a spin as well?
::: packageit.sh
@@ +144,5 @@
> +pushd "${MSYS_STAGEDIR}/mozilla-build/nsis-3.0b1"
> +mv makensis.exe makensis-3.0b1.exe
> +mv Bin/makensis.exe Bin/makensis-3.0b1.exe
> +popd
> +
Please add this to the "Install other non-MSYS packages" section instead (under the yasm install or something).
Attachment #8579669 -
Flags: review?(ryanvm) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Found the extraction path was incorrect while testing and with that fixed it works. :)
Attachment #8579669 -
Attachment is obsolete: true
Attachment #8579753 -
Flags: review+
Assignee | ||
Comment 5•10 years ago
|
||
Pushed to mozilla-build
https://hg.mozilla.org/mozilla-build/rev/758c08908381
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Blocks: MozillaBuild2.0
Updated•2 years ago
|
Product: mozilla.org → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•