NSIS 3.0a2 fixes a couple of stub installer and full installer bugs and I'd like it deployed to all buildslaves including l10n build slaves. It will be included in the next Mozilla Build which will be 1.9 in bug 962303. Support for NSIS 3.0a2 that is backwards compatible with NSIS 2.46 Unicode was added in bug 962381.

Chris, just a heads up that with Mozilla Build 1.9 released and other bugs fixed that I'd like to get this bug fixed to solve some of the bugs with the installer and stub installer. Thanks!

From an ease-of-deployment point of view, I think deploying NSIS 3.0a2 in isolation may well be quicker and easier. We layer stuff on top of MozillaBuild 1.5.1 as part of the machine install process, and since a new MozillaBuild install is destructive, upgrading the whole thing will require more testing. I'll try to find an owner for this early next week. I have some other Windows platform upgrades to do myself, so I may end up just taking it. Here's the setup file in case I'm not the one who ends up working on this: http://hg.mozilla.org/mozilla-build/file/190992f68fc9/nsis-3.0a2-setup.exe

MozillaBuild 1.10 is out now, so we might as well use the most recent package.

(In reply to Chris Cooper [:coop] from comment #2) > http://hg.mozilla.org/mozilla-build/file/190992f68fc9/nsis-3.0a2-setup.exe Starting with the above package, the installation steps are here: http://hg.mozilla.org/mozilla-build/file/cfd4e36a9762/packageit.py#l144 nsis-3.0a2-setup.exe /S /D=C:\mozilla-build\nsis-3.0a2 # wait for install to complete. Could check for makensis.exe to be sure. copy C:\mozilla-build\nsis-3.0a2\makensis.exe C:\mozilla-build\nsis-3.0a2\makensisu-3.0a2.exe copy C:\mozilla-build\nsis-3.0a2\Bin\makensis.exe C:\mozilla-build\nsis-3.0a2\Bin\makensisu-3.0a2.exe Reassigning to relops to get a GPO created.

A GPO is now active for this. The GPO copy over the NSIS 3.0a2 files that extracted from MozillaBuild 1.10.

It appears this has caused the problems described in bug 1060255 - I guess we will need to roll this change back.

I just updated the GPO to delete the NSIS 3.0a2 directory.

Mark, does this bring us back to the state the machine was before the GPO ran, or do we have to do anything else to fully do a back out and restore state? coop (as the original bug submitter): who can we work with to actually test these changes before we try pushing them out again? someone in releng (pmoore?): how do we go about getting the machines that were backed out tested and back into service?

The failure is likely due to the additional changes made to MozillaBuild not being deployed as well and is probably due to the PATH changes. See the 2nd patch in Bug 962303

It will be back to the state prior to the GPO being applied.

We'll need path changes applied in the following places before we can re-deploy: https://mxr.mozilla.org/build/search?string=nsis-2.46

I did not get to this in my queue today. I will review at 9am PT tomorrow.

Comment on attachment 8484247 [details] [diff] [review] [mozharness] Add NSIS 3.0a2 to path Review of attachment 8484247 [details] [diff] [review]: ----------------------------------------------------------------- thank you for making this one less thing I have to fight against from bitrot :)

Comment on attachment 8484246 [details] [diff] [review] [ash-mozharness] Add NSIS 3.0a2 to path Review of attachment 8484246 [details] [diff] [review]: ----------------------------------------------------------------- as mentioned in other bug, I'll look into how we want to proceed with ash. But let's land this on both for now

Comment on attachment 8484249 [details] [diff] [review] [buildbot-configs] ] Add NSIS 3.0a2 to path Review of attachment 8484249 [details] [diff] [review]: ----------------------------------------------------------------- https://hg.mozilla.org/build/buildbot-configs/rev/5afe372cc0b6

Comment on attachment 8484247 [details] [diff] [review] [mozharness] Add NSIS 3.0a2 to path Review of attachment 8484247 [details] [diff] [review]: ----------------------------------------------------------------- https://hg.mozilla.org/build/mozharness/rev/7a97ca6fb0c2

Comment on attachment 8484246 [details] [diff] [review] [ash-mozharness] Add NSIS 3.0a2 to path Review of attachment 8484246 [details] [diff] [review]: ----------------------------------------------------------------- https://hg.mozilla.org/build/ash-mozharness/rev/16fd7b9dad4e

Merged to production, and deployed.

Just to keep state here, this was rolled back. Each time we try to roll it out it breaks production because of path issues.

Just fyi, upstream released 3.0b0 on May 11th and 3.0b1 may get released today (October 6th). History: http://sourceforge.net/p/nsis/code/HEAD/tree/NSIS/trunk/Docs/src/history.but Someone should probably have a look if we're gonna need some of those fixes.

This has been lingering for a a while now. Is this an issue with how we are looking for the nsis files, or is there something that needs to be changed on the GPO side?

(In reply to Mark Cornmesser [:markco] from comment #24) > This has been lingering for a a while now. Is this an issue with how we are > looking for the nsis files, or is there something that needs to be changed > on the GPO side? Sorry, I should have been explicit. All of the releng PATH changes have deployed, so yes, we can attempt to redeploy now. To be safe though, I would like to start by deploying to *only* the 5 slaves we've been mucking with for new deployments, i.e. b-2008-ix-000[1-5].

The GPO has been deployed to the test pool. The machines should be picking up the changes within the hour.

Can I get an update for when this will be deployed?

It would be really nice if we could get this done while Gecko 38 is still on trunk so we aren't forced to support 2.46 for an entire ESR cycle. I'd also like to drop 2.46 from MozillaBuild.

I believe we're still gated on broken path issues.

I believe that is correct. I can't find the exact error. I can easily enough redeploy the gpo to test machine to see what happens. jlund: do you recall or have the error somewhere from the last time we tried this? i recall you were working with me on it?

(In reply to Mark Cornmesser [:markco] from comment #30) > I believe that is correct. I can't find the exact error. > > I can easily enough redeploy the gpo to test machine to see what happens. > > jlund: do you recall or have the error somewhere from the last time we tried > this? i recall you were working with me on it? Sorry, I was out yesterday on stat holiday. I don't think I'm the best for this. I had this as part of my 'upgrade windows things(bug 1063018)' but we closed that and left nsis stuff here. I recall I reviewed a mozharness path that was the copy of a buildbot patch: https://bug989531.bugzilla.mozilla.org/attachment.cgi?id=8484246 but I never saw the rollout or any errors. Reading scrollback it sounds like we rolled the gpo change before ensuring all jobs had nsis in the PATH env var via buildbot and mozharness. That or what we set in PATH is wrong. To get the ball rolling agin, I propose we grab a slave or two and test this out like coop suggested here: https://bugzilla.mozilla.org/show_bug.cgi?id=989531#c25 We should get lots of new logs/state from testing one slave. Since I will be looking at puppetized windows machines on my dev-master tomorrow, we could another slave with nsis in staging beside it :) Mark emailed me on the side and we are going to meet about this tomorrow.

I have disabled 0003 and 0004 for this. I will work on getting NSIS pushed out to those machines tomorrow in the am.

NSIS-3.0a2 has been pushed out to 0003 and 0004.

there has been delays on testing this due to tree closure bugs like: https://bugzil.la/1132792 attaching 0003 and 0004 to my staging master now. will report back with findings

for those with access: http://dev-master1.srv.releng.scl3.mozilla.com:8037/builders/WINNT%205.2%20mozilla-central%20build/builds/44/steps/run_script/logs/stdio http://dev-master1.srv.releng.scl3.mozilla.com:8037/builders/WINNT%206.1%20x86-64%20mozilla-central%20build/builds/6/steps/compile/logs/stdio for those without, I ran a win32 and win64 build and quickly found the nsis, path error we likely saw in production from before win32 snippet (with mozharness): 15:51:52 INFO - configure:22879: checking for Unicode NSIS version 2.46 or greater 15:51:52 INFO - configure: error: To build the installer you must have the latest MozillaBuild or Unicode NSIS version 2.46 or greater in your path. 15:51:52 INFO - *** Fix above errors and then restart with\ 15:51:52 INFO - "c:/builds/moz2_slave/m-cen-w32-00000000000000000000/build/src/mozmake.EXE -f client.mk build" 15:51:52 INFO - c:/builds/moz2_slave/m-cen-w32-00000000000000000000/build/src/client.mk:361: recipe for target 'configure' failed 15:51:52 INFO - mozmake.EXE[2]: *** [configure] Error 1 15:51:52 INFO - mozmake.EXE[2]: Leaving directory 'c:/builds/moz2_slave/m-cen-w32-00000000000000000000/build/src' 15:51:52 INFO - c:/builds/moz2_slave/m-cen-w32-00000000000000000000/build/src/client.mk:375: recipe for target 'c:/builds/moz2_slave/m-cen-w32-00000000000000000000/build/src/obj-firefox/Makefile' failed 15:51:52 INFO - mozmake.EXE[1]: *** [c:/builds/moz2_slave/m-cen-w32-00000000000000000000/build/src/obj-firefox/Makefile] Error 2 15:51:52 INFO - mozmake.EXE[1]: Leaving directory 'c:/builds/moz2_slave/m-cen-w32-00000000000000000000/build/src' 15:51:52 INFO - client.mk:171: recipe for target 'build' failed 15:51:52 INFO - mozmake.EXE: *** [build] Error 2 15:51:52 INFO - 0 compiler warnings present. 15:51:52 INFO - 2 15:51:52 ERROR - Return code: 1 15:51:52 FATAL - 'mach build' did not run successfully. Please check log for errors. 15:51:52 FATAL - Running post_fatal callback... 15:51:52 FATAL - Exiting -1 15:51:52 INFO - Running post-run listener: _summarize 15:51:52 ERROR - # TBPL FAILURE # 15:51:52 INFO - ##### 15:51:52 INFO - ##### FxDesktopBuild summary: 15:51:52 INFO - ##### 15:51:52 ERROR - # TBPL FAILURE # notice this was my path: 15:26:27 INFO - 'PATH': 'C:/mozilla-build/nsis-3.0a2;C:/mozilla-build/nsis-2.46u;C:/mozilla-build/python27;C:/mozilla-build/buildbotve/scripts;' so it definitely is in my path. looking into dark unfamiliar corners, I see: http://mxr.mozilla.org/mozilla-central/source/configure.in#6372 Playing around a bit, I think we are running into issues here: http://mxr.mozilla.org/mozilla-central/source/configure.in#6349 cltbld@B-2008-IX-0004 ~ $ PATH=/c/mozilla-build/nsis-2.46u makensisu-2.46.exe -version v2.46-Unicode cltbld@B-2008-IX-0004 ~ $ PATH=/c/mozilla-build/nsis-3.0a2 makensisu-3.0a2.exe -version Error initalizing CEXEBuild: can't open file so we are having trouble 'initalizing' ;) should note we at least have permissions. -rwxr-xr-x 1 cltbld Administrators 2560 Dec 24 2013 makensisu-3.0a2.exe

/c/mozilla-build/nsis-3.0a2/makensisu-3.0a2.exe is a stub for /c/mozilla-build/nsis-3.0a2/Bin/makensisu-3.0a2.exe Does /c/mozilla-build/nsis-3.0a2/Bin/makensisu-3.0a2.exe also exist?

/c/mozilla-build/nsis-3.0a2/Bin/makensisu-3.0a2.exe exists and yields the same error output when called

What happens if you cd /c/mozilla-build/nsis-3.0a2/ and then ./makensisu-3.0a2.exe -version?

Could you compare the permissions in explorer of the nsis-2.46u and the nsis-3.0a2 directories? If they are the same please compare the permissions of nsis-2.46u/makensisu-2.46.exe and nsis-3.0a2/makensisu-3.0a2.exe files?

Also, what happens when you just issuing makensisu-3.0a2.exe in case there are problems with passing the argument

I took a look at the NSIS code where this error happens and it might be due to removing the NSIS uninstaller though I am at a loss as to why it would happen with the build system and not locally. Try copying the NSIS.exe to ninst-nsis.exe.

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #41) > I took a look at the NSIS code where this error happens and it might be due > to removing the NSIS uninstaller though I am at a loss as to why it would > happen with the build system and not locally. Try copying the NSIS.exe to > ninst-nsis.exe. I meant uninst-nsis.exe

myself and rstrong touched base over irc and tried everything from comment 38-43. even with a real copy of uninst-nsis.exe, I still got the same error as before. So that I don't act like a slow proxy, I am going to promote rstrong's permissions and give him access for b-2008-ix-0004. I'll update 1134377 when he actually has permission to access

Has there been any update on this?

(In reply to Mark Cornmesser [:markco] from comment #45) > Has there been any update on this? I'm not sure your issue you see in https://bugzil.la/1134980 is related. We should be able to use /c/mozilla-build/nsis-2.46u but for some reason, that's failing to get recognized on 0010

(In reply to Jordan Lund (:jlund) from comment #46) > (In reply to Mark Cornmesser [:markco] from comment #45) > > Has there been any update on this? > > I'm not sure your issue you see in https://bugzil.la/1134980 is related. We > should be able to use /c/mozilla-build/nsis-2.46u but for some reason, > that's failing to get recognized on 0010 nvm

I finally found time to look... I diff'd the nsis-3.0a2 from MozillaBuild against the nsis-3.0a2 on b-2008-ix-0004 and found the following files missing from the c:\mozilla-build\nsis-3.0a2\ directory on b-2008-ix-0004. After adding these files to b-2008-ix-0004 everything worked fine. Only in nsis-3.0a2/Contrib: Graphics Only in nsis-3.0a2/Docs: AdvSplash Only in nsis-3.0a2/Docs: Banner Only in nsis-3.0a2/Docs: BgImage Only in nsis-3.0a2/Docs: Dialer Only in nsis-3.0a2/Docs/InstallOptions: Changelog.txt Only in nsis-3.0a2/Docs: Math Only in nsis-3.0a2/Docs/Modern UI: Changelog.txt Only in nsis-3.0a2/Docs/Modern UI: images Only in nsis-3.0a2/Docs/Modern UI 2: images Only in nsis-3.0a2/Docs: MultiUser Only in nsis-3.0a2/Docs: NSISdl Only in nsis-3.0a2/Docs: Splash Only in nsis-3.0a2/Docs: StartMenu Only in nsis-3.0a2/Docs: StrFunc Only in nsis-3.0a2/Docs/System: WhatsNew.txt Only in nsis-3.0a2/Docs/makensisw: License.txt Only in nsis-3.0a2/Docs: nsExec Only in nsis-3.0a2/Examples/Math: mathtest.txt Only in nsis-3.0a2/Examples/Plugin: exdll.dsp Only in nsis-3.0a2/Examples/Plugin: exdll.dsw Only in nsis-3.0a2/Examples/VPatch: newfile.txt Only in nsis-3.0a2/Examples/VPatch: oldfile.txt Only in nsis-3.0a2/Examples/VPatch: patch.pat Only in nsis-3.0a2/Include/Win: WinError.nsh Only in nsis-3.0a2/Menu/images: line.gif Only in nsis-3.0a2/Menu/images: site.gif Only in nsis-3.0a2/Stubs: uninst I'm done with the builder and if you need my assistance just let me know.

Note that in several cases above a missing directory name is listed and it should be assumed that the directory along with all of its contents are missing when compared to the directory in MozillaBuild.

I pulled the files directly out of the MozillaBuild package, but it was an older version, 1.9. I will dive back into this over the next few days.

I don't know if I am missing something, but I am not seeing these files. I first downloaded the MozillaBuild package from here: https://wiki.mozilla.org/MozillaBuild I extracted this out and spot checked for a few files, and did not see any of the above files. I also downloaded the zip file from here: http://sourceforge.net/projects/nsis/files/NSIS%203%20Pre-release/3.0a2/ After a extraction I didn't see the files.

Which entries from comment 48 aren't you seeing? Downloaded nsis-3.0a2.zip from sourceforge http://iweb.dl.sourceforge.net/project/nsis/NSIS%203%20Pre-release/3.0a2/nsis-3.0a2.zip Extracted it and from the root ls -R .: Bin COPYING Contrib Docs Examples Include Menu NSIS.chm NSIS.exe Plugins Stubs makensis.exe makensisw.exe nsisconf.nsh ./Bin: GenPat.exe LibraryLocal.exe MakeLangId.exe RegTool.bin makensis.exe zip2exe.exe zlib1.dll ./Contrib: Graphics Language files Modern UI Modern UI 2 UIs zip2exe ./Contrib/Graphics: Checks Header Icons Wizard ./Contrib/Graphics/Checks: big.bmp classic-cross.bmp classic.bmp colorful.bmp grey-cross.bmp grey.bmp modern.bmp red-round.bmp red.bmp simple-round.bmp simple-round2.bmp simple.bmp ./Contrib/Graphics/Header: nsis-r.bmp nsis.bmp orange-nsis.bmp orange-r-nsis.bmp orange-r.bmp orange-uninstall-nsis.bmp orange-uninstall-r-nsis.bmp orange-uninstall-r.bmp orange-uninstall.bmp orange.bmp win.bmp ./Contrib/Graphics/Icons: arrow-install.ico arrow-uninstall.ico arrow2-install.ico arrow2-uninstall.ico box-install.ico box-uninstall.ico classic-install.ico classic-uninstall.ico llama-blue.ico llama-grey.ico modern-install-blue-full.ico modern-install-blue.ico modern-install-colorful.ico modern-install-full.ico modern-install.ico modern-uninstall-blue-full.ico modern-uninstall-blue.ico modern-uninstall-colorful.ico modern-uninstall-full.ico modern-uninstall.ico nsis1-install.ico nsis1-uninstall.ico orange-install-nsis.ico orange-install.ico orange-uninstall-nsis.ico orange-uninstall.ico pixel-install.ico pixel-uninstall.ico win-install.ico win-uninstall.ico ./Contrib/Graphics/Wizard: arrow.bmp llama.bmp nsis.bmp nullsoft.bmp orange-nsis.bmp orange-uninstall-nsis.bmp orange-uninstall.bmp orange.bmp win.bmp ./Contrib/Language files: Afrikaans.nlf Afrikaans.nsh Albanian.nlf Albanian.nsh Arabic.nlf Arabic.nsh Asturian.nlf Asturian.nsh Basque.nlf Basque.nsh Belarusian.nlf Belarusian.nsh Bosnian.nlf Bosnian.nsh Breton.nlf Breton.nsh Bulgarian.nlf Bulgarian.nsh Catalan.nlf Catalan.nsh Croatian.nlf Croatian.nsh Czech.nlf Czech.nsh Danish.nlf Danish.nsh Dutch.nlf Dutch.nsh English.nlf English.nsh Esperanto.nlf Esperanto.nsh Estonian.nlf Estonian.nsh Farsi.nlf Farsi.nsh Finnish.nlf Finnish.nsh French.nlf French.nsh Galician.nlf Galician.nsh Georgian.nlf Georgian.nsh German.nlf German.nsh Greek.nlf Greek.nsh Hebrew.nlf Hebrew.nsh Hungarian.nlf Hungarian.nsh Icelandic.nlf Icelandic.nsh Indonesian.nlf Indonesian.nsh Irish.nlf Irish.nsh Italian.nlf Italian.nsh Japanese.nlf Japanese.nsh Korean.nlf Korean.nsh Kurdish.nlf Kurdish.nsh Latvian.nlf Latvian.nsh Lithuanian.nlf Lithuanian.nsh Luxembourgish.nlf Luxembourgish.nsh Macedonian.nlf Macedonian.nsh Malay.nlf Malay.nsh Mongolian.nlf Mongolian.nsh Norwegian.nlf Norwegian.nsh NorwegianNynorsk.nlf NorwegianNynorsk.nsh Pashto.nlf Pashto.nsh Polish.nlf Polish.nsh Portuguese.nlf Portuguese.nsh PortugueseBR.nlf PortugueseBR.nsh Romanian.nlf Romanian.nsh Russian.nlf Russian.nsh ScotsGaelic.nlf ScotsGaelic.nsh Serbian.nlf Serbian.nsh SerbianLatin.nlf SerbianLatin.nsh SimpChinese.nlf SimpChinese.nsh Slovak.nlf Slovak.nsh Slovenian.nlf Slovenian.nsh Spanish.nlf Spanish.nsh SpanishInternational.nlf SpanishInternational.nsh Swedish.nlf Swedish.nsh Thai.nlf Thai.nsh TradChinese.nlf TradChinese.nsh Turkish.nlf Turkish.nsh Ukrainian.nlf Ukrainian.nsh Uzbek.nlf Uzbek.nsh Vietnamese.nlf Vietnamese.nsh Welsh.nlf Welsh.nsh ./Contrib/Modern UI: System.nsh ioSpecial.ini ./Contrib/Modern UI 2: Deprecated.nsh Interface.nsh Localization.nsh MUI2.nsh Pages Pages.nsh ./Contrib/Modern UI 2/Pages: Components.nsh Directory.nsh Finish.nsh InstallFiles.nsh License.nsh StartMenu.nsh UninstallConfirm.nsh Welcome.nsh ./Contrib/UIs: default.exe modern.exe modern_headerbmp.exe modern_headerbmpr.exe modern_nodesc.exe modern_smalldesc.exe sdbarker_tiny.exe ./Contrib/zip2exe: Base.nsh Classic.nsh Modern.nsh ./Docs: AdvSplash Banner BgImage Dialer InstallOptions Math Modern UI Modern UI 2 MultiUser NSISdl Splash StartMenu StrFunc System VPatch makensisw nsDialogs nsExec ./Docs/AdvSplash: advsplash.txt ./Docs/Banner: Readme.txt ./Docs/BgImage: BgImage.txt ./Docs/Dialer: Dialer.txt ./Docs/InstallOptions: Changelog.txt Readme.html ./Docs/Math: Math.txt ./Docs/Modern UI: Changelog.txt License.txt Readme.html images ./Docs/Modern UI/images: closed.gif header.gif open.gif screen1.png screen2.png ./Docs/Modern UI 2: License.txt Readme.html images ./Docs/Modern UI 2/images: closed.gif header.gif open.gif screen1.png screen2.png ./Docs/MultiUser: Readme.html ./Docs/NSISdl: License.txt ReadMe.txt ./Docs/Splash: splash.txt ./Docs/StartMenu: Readme.txt ./Docs/StrFunc: StrFunc.txt ./Docs/System: System.html WhatsNew.txt ./Docs/VPatch: Readme.html ./Docs/makensisw: License.txt Readme.txt ./Docs/nsDialogs: Readme.html ./Docs/nsExec: nsExec.txt ./Examples: AdvSplash Banner BgImage FileFunc.ini FileFunc.nsi FileFuncTest.nsi InstallOptions Library.nsi LogicLib.nsi Math Memento.nsi Modern UI Plugin Splash StartMenu StrFunc.nsi System TextFunc.ini TextFunc.nsi TextFuncTest.nsi UserInfo UserVars.nsi VPatch VersionInfo.nsi WordFunc.ini WordFunc.nsi WordFuncTest.nsi bigtest.nsi example1.nsi example2.nsi gfx.nsi languages.nsi makensis.nsi nsDialogs nsExec one-section.nsi primes.nsi rtest.nsi silent.nsi unicode.nsi viewhtml.nsi waplugin.nsi ./Examples/AdvSplash: Example.nsi ./Examples/Banner: Example.nsi ./Examples/BgImage: Example.nsi ./Examples/InstallOptions: test.ini test.nsi testimgs.ini testimgs.nsi testlink.ini testlink.nsi testnotify.ini testnotify.nsi ./Examples/Math: math.nsi mathtest.ini mathtest.nsi mathtest.txt ./Examples/Modern UI: Basic.nsi HeaderBitmap.nsi MultiLanguage.nsi StartMenu.nsi WelcomeFinish.nsi ./Examples/Plugin: exdll-vs2008.sln exdll-vs2008.vcproj exdll.c exdll.dpr exdll.dsp exdll.dsw exdll_with_unit.dpr extdll.inc nsis nsis.pas ./Examples/Plugin/nsis: api.h nsis_tchar.h pluginapi-x86-ansi.lib pluginapi-x86-unicode.lib pluginapi.h ./Examples/Splash: Example.nsi ./Examples/StartMenu: Example.nsi ./Examples/System: Resource.dll SysFunc.nsh System.nsh System.nsi ./Examples/UserInfo: UserInfo.nsi ./Examples/VPatch: example.nsi newfile.txt oldfile.txt patch.pat ./Examples/nsDialogs: InstallOptions.nsi example.nsi timer.nsi welcome.nsi ./Examples/nsExec: test.nsi ./Include: Colors.nsh FileFunc.nsh InstallOptions.nsh LangFile.nsh Library.nsh LogicLib.nsh MUI.nsh MUI2.nsh Memento.nsh MultiUser.nsh Sections.nsh StrFunc.nsh TextFunc.nsh UpgradeDLL.nsh Util.nsh VB6RunTime.nsh VPatchLib.nsh Win WinCore.nsh WinMessages.nsh WinVer.nsh WordFunc.nsh nsDialogs.nsh x64.nsh ./Include/Win: COM.nsh Propkey.nsh WinDef.nsh WinError.nsh WinNT.nsh WinUser.nsh ./Menu: images index.html ./Menu/images: header.gif line.gif site.gif ./Plugins: x86-ansi x86-unicode ./Plugins/x86-ansi: AdvSplash.dll Banner.dll BgImage.dll Dialer.dll InstallOptions.dll LangDLL.dll Math.dll NSISdl.dll Splash.dll StartMenu.dll System.dll TypeLib.dll UserInfo.dll VPatch.dll nsDialogs.dll nsExec.dll ./Plugins/x86-unicode: AdvSplash.dll Banner.dll BgImage.dll Dialer.dll InstallOptions.dll LangDLL.dll Math.dll NSISdl.dll Splash.dll StartMenu.dll System.dll TypeLib.dll UserInfo.dll VPatch.dll nsDialogs.dll nsExec.dll ./Stubs: bzip2-x86-ansi bzip2-x86-unicode bzip2_solid-x86-ansi bzip2_solid-x86-unicode lzma-x86-ansi lzma-x86-unicode lzma_solid-x86-ansi lzma_solid-x86-unicode uninst zlib-x86-ansi zlib-x86-unicode zlib_solid-x86-ansi zlib_solid-x86-unicode Downloaded the latest MozillaBuild https://ftp.mozilla.org/pub/mozilla.org/mozilla/libraries/win32/MozillaBuildSetup-Latest.exe For reference this is the same as https://ftp.mozilla.org/pub/mozilla.org/mozilla/libraries/win32/MozillaBuildSetup-1.11.0.exe Ran the installer cd into mozilla-build/nsis-3.0a2 and ls -R .: Bin COPYING Contrib Docs Examples Include Menu NSIS.chm NSIS.exe Plugins Stubs makensisu-3.0a2.exe makensisw.exe nsisconf.nsh ./Bin: GenPat.exe LibraryLocal.exe MakeLangId.exe RegTool.bin makensisu-3.0a2.exe zip2exe.exe zlib1.dll ./Contrib: Graphics Language files Modern UI Modern UI 2 UIs zip2exe ./Contrib/Graphics: Checks Header Icons Wizard ./Contrib/Graphics/Checks: big.bmp classic-cross.bmp classic.bmp colorful.bmp grey-cross.bmp grey.bmp modern.bmp red-round.bmp red.bmp simple-round.bmp simple-round2.bmp simple.bmp ./Contrib/Graphics/Header: nsis-r.bmp nsis.bmp orange-nsis.bmp orange-r-nsis.bmp orange-r.bmp orange-uninstall-nsis.bmp orange-uninstall-r-nsis.bmp orange-uninstall-r.bmp orange-uninstall.bmp orange.bmp win.bmp ./Contrib/Graphics/Icons: arrow-install.ico arrow-uninstall.ico arrow2-install.ico arrow2-uninstall.ico box-install.ico box-uninstall.ico classic-install.ico classic-uninstall.ico llama-blue.ico llama-grey.ico modern-install-blue-full.ico modern-install-blue.ico modern-install-colorful.ico modern-install-full.ico modern-install.ico modern-uninstall-blue-full.ico modern-uninstall-blue.ico modern-uninstall-colorful.ico modern-uninstall-full.ico modern-uninstall.ico nsis1-install.ico nsis1-uninstall.ico orange-install-nsis.ico orange-install.ico orange-uninstall-nsis.ico orange-uninstall.ico pixel-install.ico pixel-uninstall.ico win-install.ico win-uninstall.ico ./Contrib/Graphics/Wizard: arrow.bmp llama.bmp nsis.bmp nullsoft.bmp orange-nsis.bmp orange-uninstall-nsis.bmp orange-uninstall.bmp orange.bmp win.bmp ./Contrib/Language files: Afrikaans.nlf Afrikaans.nsh Albanian.nlf Albanian.nsh Arabic.nlf Arabic.nsh Asturian.nlf Asturian.nsh Basque.nlf Basque.nsh Belarusian.nlf Belarusian.nsh Bosnian.nlf Bosnian.nsh Breton.nlf Breton.nsh Bulgarian.nlf Bulgarian.nsh Catalan.nlf Catalan.nsh Croatian.nlf Croatian.nsh Czech.nlf Czech.nsh Danish.nlf Danish.nsh Dutch.nlf Dutch.nsh English.nlf English.nsh Esperanto.nlf Esperanto.nsh Estonian.nlf Estonian.nsh Farsi.nlf Farsi.nsh Finnish.nlf Finnish.nsh French.nlf French.nsh Galician.nlf Galician.nsh Georgian.nlf Georgian.nsh German.nlf German.nsh Greek.nlf Greek.nsh Hebrew.nlf Hebrew.nsh Hungarian.nlf Hungarian.nsh Icelandic.nlf Icelandic.nsh Indonesian.nlf Indonesian.nsh Irish.nlf Irish.nsh Italian.nlf Italian.nsh Japanese.nlf Japanese.nsh Korean.nlf Korean.nsh Kurdish.nlf Kurdish.nsh Latvian.nlf Latvian.nsh Lithuanian.nlf Lithuanian.nsh Luxembourgish.nlf Luxembourgish.nsh Macedonian.nlf Macedonian.nsh Malay.nlf Malay.nsh Mongolian.nlf Mongolian.nsh Norwegian.nlf Norwegian.nsh NorwegianNynorsk.nlf NorwegianNynorsk.nsh Pashto.nlf Pashto.nsh Polish.nlf Polish.nsh Portuguese.nlf Portuguese.nsh PortugueseBR.nlf PortugueseBR.nsh Romanian.nlf Romanian.nsh Russian.nlf Russian.nsh ScotsGaelic.nlf ScotsGaelic.nsh Serbian.nlf Serbian.nsh SerbianLatin.nlf SerbianLatin.nsh SimpChinese.nlf SimpChinese.nsh Slovak.nlf Slovak.nsh Slovenian.nlf Slovenian.nsh Spanish.nlf Spanish.nsh SpanishInternational.nlf SpanishInternational.nsh Swedish.nlf Swedish.nsh Thai.nlf Thai.nsh TradChinese.nlf TradChinese.nsh Turkish.nlf Turkish.nsh Ukrainian.nlf Ukrainian.nsh Uzbek.nlf Uzbek.nsh Vietnamese.nlf Vietnamese.nsh Welsh.nlf Welsh.nsh ./Contrib/Modern UI: System.nsh ioSpecial.ini ./Contrib/Modern UI 2: Deprecated.nsh Interface.nsh Localization.nsh MUI2.nsh Pages Pages.nsh ./Contrib/Modern UI 2/Pages: Components.nsh Directory.nsh Finish.nsh InstallFiles.nsh License.nsh StartMenu.nsh UninstallConfirm.nsh Welcome.nsh ./Contrib/UIs: default.exe modern.exe modern_headerbmp.exe modern_headerbmpr.exe modern_nodesc.exe modern_smalldesc.exe sdbarker_tiny.exe ./Contrib/zip2exe: Base.nsh Classic.nsh Modern.nsh ./Docs: AdvSplash Banner BgImage Dialer InstallOptions Math Modern UI Modern UI 2 MultiUser NSISdl Splash StartMenu StrFunc System VPatch makensisw nsDialogs nsExec ./Docs/AdvSplash: advsplash.txt ./Docs/Banner: Readme.txt ./Docs/BgImage: BgImage.txt ./Docs/Dialer: Dialer.txt ./Docs/InstallOptions: Changelog.txt Readme.html ./Docs/Math: Math.txt ./Docs/Modern UI: Changelog.txt License.txt Readme.html images ./Docs/Modern UI/images: closed.gif header.gif open.gif screen1.png screen2.png ./Docs/Modern UI 2: License.txt Readme.html images ./Docs/Modern UI 2/images: closed.gif header.gif open.gif screen1.png screen2.png ./Docs/MultiUser: Readme.html ./Docs/NSISdl: License.txt ReadMe.txt ./Docs/Splash: splash.txt ./Docs/StartMenu: Readme.txt ./Docs/StrFunc: StrFunc.txt ./Docs/System: System.html WhatsNew.txt ./Docs/VPatch: Readme.html ./Docs/makensisw: License.txt Readme.txt ./Docs/nsDialogs: Readme.html ./Docs/nsExec: nsExec.txt ./Examples: AdvSplash Banner BgImage FileFunc.ini FileFunc.nsi FileFuncTest.nsi InstallOptions Library.nsi LogicLib.nsi Math Memento.nsi Modern UI Plugin Splash StartMenu StrFunc.nsi System TextFunc.ini TextFunc.nsi TextFuncTest.nsi UserInfo UserVars.nsi VPatch VersionInfo.nsi WordFunc.ini WordFunc.nsi WordFuncTest.nsi bigtest.nsi example1.nsi example2.nsi gfx.nsi languages.nsi makensis.nsi nsDialogs nsExec one-section.nsi primes.nsi rtest.nsi silent.nsi unicode.nsi viewhtml.nsi waplugin.nsi ./Examples/AdvSplash: Example.nsi ./Examples/Banner: Example.nsi ./Examples/BgImage: Example.nsi ./Examples/InstallOptions: test.ini test.nsi testimgs.ini testimgs.nsi testlink.ini testlink.nsi testnotify.ini testnotify.nsi ./Examples/Math: math.nsi mathtest.ini mathtest.nsi mathtest.txt ./Examples/Modern UI: Basic.nsi HeaderBitmap.nsi MultiLanguage.nsi StartMenu.nsi WelcomeFinish.nsi ./Examples/Plugin: exdll-vs2008.sln exdll-vs2008.vcproj exdll.c exdll.dpr exdll.dsp exdll.dsw exdll_with_unit.dpr extdll.inc nsis nsis.pas ./Examples/Plugin/nsis: api.h nsis_tchar.h pluginapi-x86-ansi.lib pluginapi-x86-unicode.lib pluginapi.h ./Examples/Splash: Example.nsi ./Examples/StartMenu: Example.nsi ./Examples/System: Resource.dll SysFunc.nsh System.nsh System.nsi ./Examples/UserInfo: UserInfo.nsi ./Examples/VPatch: example.nsi newfile.txt oldfile.txt patch.pat ./Examples/nsDialogs: InstallOptions.nsi example.nsi timer.nsi welcome.nsi ./Examples/nsExec: test.nsi ./Include: Colors.nsh FileFunc.nsh InstallOptions.nsh LangFile.nsh Library.nsh LogicLib.nsh MUI.nsh MUI2.nsh Memento.nsh MultiUser.nsh Sections.nsh StrFunc.nsh TextFunc.nsh UpgradeDLL.nsh Util.nsh VB6RunTime.nsh VPatchLib.nsh Win WinCore.nsh WinMessages.nsh WinVer.nsh WordFunc.nsh nsDialogs.nsh x64.nsh ./Include/Win: COM.nsh Propkey.nsh WinDef.nsh WinError.nsh WinNT.nsh WinUser.nsh ./Menu: images index.html ./Menu/images: header.gif line.gif site.gif ./Plugins: x86-ansi x86-unicode ./Plugins/x86-ansi: Banner.dll BgImage.dll Dialer.dll InstallOptions.dll LangDLL.dll Math.dll StartMenu.dll System.dll TypeLib.dll UserInfo.dll VPatch.dll advsplash.dll nsDialogs.dll nsExec.dll nsisdl.dll splash.dll ./Plugins/x86-unicode: Banner.dll BgImage.dll Dialer.dll InstallOptions.dll LangDLL.dll Math.dll StartMenu.dll System.dll TypeLib.dll UserInfo.dll VPatch.dll advsplash.dll nsDialogs.dll nsExec.dll nsisdl.dll splash.dll ./Stubs: bzip2-x86-ansi bzip2-x86-unicode bzip2_solid-x86-ansi bzip2_solid-x86-unicode lzma-x86-ansi lzma-x86-unicode lzma_solid-x86-ansi lzma_solid-x86-unicode uninst zlib-x86-ansi zlib-x86-unicode zlib_solid-x86-ansi zlib_solid-x86-unicode

Note: the MozillaBuild install of nsis 3.0a2 renames two files so this version can be detected during configure in the nsis-3.0a2/ dir makensis.exe is renamed to makensisu-3.0a2.exe In the nsis-3.0a2/Bin/ dir makensis.exe is renamed to makensisu-3.0a2.exe

At second look, the sourceforge zip file seems complete. However, the what is in the Mozillabuild package seems incomplete. I have a GPO ready to go that is based on the sourceforge package with the files mention in comment 35 renamed ready. Jlund: Is there a machine we want to test on?

I suspect you are using 7-zip to extract the files from https://ftp.mozilla.org/pub/mozilla.org/mozilla/libraries/win32/MozillaBuildSetup-Latest.exe When I do so there are also missing files... running the installer will give you all of the files.

> Jlund: Is there a machine we want to test on? we can use b-2008-ix-0003 again. iiuc, it still has the original NSIS 3.0a2 install that was incomplete on it so not sure if we need to re-image it? Either way it is out of production and I can hook up to my staging master at any time

I'd like to see this change ride the trains and the configure change to use 3.0a2 is on all branches. To work around this, since 3.0b1 has been out for awhile and stable I'd like to go with 3.0b1 and let the configure change ride the trains. I'll post in this bug if that is the direction we'll take.

b-2008-ix-0003 is ready for testing.

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #57) > I'd like to see this change ride the trains and the configure change to use > 3.0a2 is on all branches. To work around this, since 3.0b1 has been out for > awhile and stable I'd like to go with 3.0b1 and let the configure change > ride the trains. I'll post in this bug if that is the direction we'll take. Let's go with NSIS 3.0b1. The reasoning is as follows: We've had no Firefox releases using 3.0a2 and this way 3.0b1 can ride the trains. NSIS 3.0b1 has been out for quite some time and has shown itself to be as stable as 3.0a2. to install download nsis-3.0b1.zip from http://sourceforge.net/projects/nsis/files/NSIS%203%20Pre-release/3.0b1/nsis-3.0b1.zip/download extract it to <path to mozilla-build>\nsis-3.0b1 Rename in the nsis-3.0b1 directory makensis.exe to makensis-3.0b1.exe Rename in the nsis-3.0b1\Bin makensis.exe to makensis-3.0b1.exe Change the paths (see attachments in this bug) from C:/mozilla-build/nsis-3.0a2 to C:/mozilla-build/nsis-3.0b1 I have verified locally that this works after changing configure to find NSIS 3.0b1

b-2008-ix-0003 now has nsis-3.0b1 on it and is ready for testing.

jlund, a new configure change will be needed to verify that it builds on this system. We can do one of the following to verify. a) I can verify it b) I can give you the configure patch and you can verify it. c) I can get the configure patch landed on m-c and it can be verified using m-c. Which would you like to do?

Bug 1144934 will update configure.in

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #61) > jlund, a new configure change will be needed to verify that it builds on > this system. We can do one of the following to verify. > > a) I can verify it > b) I can give you the configure patch and you can verify it. > c) I can get the configure patch landed on m-c and it can be verified using > m-c. > > Which would you like to do? I'm easy, essentially I am applying the following if it's not in tree by the time I go to test this correct: https://bug1144934.bugzilla.mozilla.org/attachment.cgi?id=8579664 ?

That works and the build log should show which version of NSIS was picked up by configure. Thanks!

Do we want to move forward with 3.0b1? Should we get it added into the mozilla-build package?

(In reply to Mark Cornmesser [:markco] from comment #65) > Do we want to move forward with 3.0b1? Should we get it added into the > mozilla-build package? That was done in bug 1144938 :)

:ryanvm: When will that be released and available on ftp? that's the package we use.

Within the next week or two. I still have a couple bugs to iron out before the final release.

You can download the package from the mozilla-build repo https://hg.mozilla.org/mozilla-build/raw-file/758c08908381/nsis-3.0b1.zip and then extract it to <path to mozilla-build>\ and it should create a nsis-3.0b1 directory with the NSIS files inside. Rename in the nsis-3.0b1 directory makensis.exe to makensis-3.0b1.exe Rename in the nsis-3.0b1\Bin makensis.exe to makensis-3.0b1.exe Change the paths (see attachments in this bug) from C:/mozilla-build/nsis-3.0a2 to C:/mozilla-build/nsis-3.0b1

in the meantime, I'm testing the install we do have on 003 in staging: http://dev-master2.bb.releng.use1.mozilla.com:8037/builders/WINNT%205.2%20mozilla-central%20build/builds/13636 will report back with a log result of this job

(In reply to Jordan Lund (:jlund) from comment #70) > in the meantime, I'm testing the install we do have on 003 in staging: > http://dev-master2.bb.releng.use1.mozilla.com:8037/builders/WINNT%205. > 2%20mozilla-central%20build/builds/13636 > > will report back with a log result of this job so I have run this a few times thinking there was a problem with my staging setup but I am starting to think that my errors are related to new nsis. the good news is it looks like it picked up the new nsis: 22:37:40 INFO - checking for makensis-3.0b1.exe... /c/mozilla-build/nsis-3.0b1/makensis-3.0b1.exe 22:37:40 INFO - yes 22:37:40 INFO - checking for Unicode NSIS version 2.46 or greater... yes the bad news is, my builds keep timing out at the end. rstrong, any ideas here? I notice there is mentions of nsis in the logs near the end, could this be at play? I'm going to start clean and revert back to the old nsis to see if we can conclude it's 3.0b1 or the way it's installed. I've uploaded the log publicly here: http://people.mozilla.org/~jlund/nsis_log_failure.txt

It looks like it complete each of the NSIS compilations and failed after that under locale. cd ../../dist/l10n-stage && test $(cat firefox/update.locale) = x-test I don't know the purpose of x-test as a locale though that looks suspicious. It would be interesting to see the log with the exact same config rebuilding without the /c/mozilla-build/nsis-3.0b1 dir present since that will make it fallback to the older NSIS.

> It would be interesting to see the log with the exact same config rebuilding > without the /c/mozilla-build/nsis-3.0b1 dir present since that will make it > fallback to the older NSIS. I've kicked off another build without nsis-3.0b1 in the PATH

jlund, what were the results without nsis-3.0b1 in the PATH?

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #74) > jlund, what were the results without nsis-3.0b1 in the PATH? you were correct. the build failed in the same spot: full log: http://people.mozilla.org/~jlund/win32_without_new_NSIS.txt snippet: 00:59:14 INFO - 'PATH': 'C:/mozilla-build/nsis-2.46u;C:/mozilla-build/python27;C:/mozilla-build/buildbotve/scripts;C:\\mozilla-build\\nsis-3.0a2;C:\\mozilla-build\\nsis-2.46u;C:\\mozilla-build\\python27;C:\\mozilla-build\\buildbotve\\scripts;C:\\mozilla-build\\msys\\local\\bin;c:\\mozilla-build\\wget;c:\\mozilla-build\\7zip;c:\\mozilla-build\\blat261\\full;c:\\mozilla-build\\python;c:\\mozilla-build\\svn-win32-1.6.3\\bin;c:\\mozilla-build\\upx203w;c:\\mozilla-build\\emacs-22.3\\bin;c:\\mozilla-build\\info-zip;c:\\mozilla-build\\nsis-2.22;c:\\mozilla-build\\nsis-2.33u;c:\\mozilla-build\\nsis-2.46u;c:\\mozilla-build\\wix-351728;c:\\mozilla-build\\hg;c:\\mozilla-build\\python\\Scripts;c:\\mozilla-build\\kdiff3;c:\\mozilla-build\\yasm;.;C:\\mozilla-build\\msys\\local\\bin;C:\\mozilla-build\\msys\\mingw\\bin;C:\\mozilla-build\\msys\\bin;c:\\windows\\system32;c:\\windows;c:\\windows\\System32\\Wbem;c:\\windows\\System32\\WindowsPowerShell\\v1.0\\;c:\\mozilla-build;c:\\mozilla-build\\python27;c:\\mozilla-build\\python27\\Scripts;C:\\mozilla-build\\msys\\bin;c:\\mozilla-build\\vim\\vim72;c:\\mozilla-build\\wget;c:\\mozilla-build\\info-zip;c:\\CoreUtils\\bin;c:\\mozilla-build\\buildbotve\\scripts;c:\\Program Files (x86)\\Microsoft SQL Server\\100\\Tools\\Binn\\;c:\\Program Files\\Microsoft SQL Server\\100\\Tools\\Binn\\;c:\\Program Files\\Microsoft SQL Server\\100\\DTS\\Binn\\;c:\\Program Files (x86)\\Windows Kits\\8.0\\Windows Performance Toolkit\\;c:\\Program Files (x86)\\Windows Kits\\8.1\\Windows Performance Toolkit\\;c:\\Program Files\\Microsoft SQL Server\\110\\Tools\\Binn\\;c:\\Program Files (x86)\\Microsoft SDKs\\TypeScript\\1.0\\;c:\\mozilla-build\\hg;c:\\mozilla-build\\moztools-x64\\bin;c:\\mozilla-build\\vim\\vim72', side-note: that path needs a clean up. I think we are inheriting things from os.env and appending it in at least mozharness, possibly at buildbot level too. However, nsis-2.46u is first in the path so it should be the one that is picked up as proven here: 01:00:21 INFO - checking for makensisu-2.46.exe... /c/mozilla-build/nsis-2.46u/makensisu-2.46.exe 01:00:21 INFO - yes 01:00:22 INFO - checking for Unicode NSIS version 2.46 or greater... yes So, since both 3.0b1 and 2.46u seem to end up at the same stage, I suspect this is an issue with the specific slave or the staging environment. coop, rstrong: I propose we install 3.0b1 on a new fresh slave, let it into production and see how it fairs after one build. This would 1) eliminate the chance this is a slave/environment error and 2) speed up the process. any objections?

I'm good with doing that.

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #76) > I'm good with doing that. +1

markco: can you install 3.0b1 on the following try machine when time allows? I have started to disable: b-2008-ix-0019 once this build is finished[1] it will be fully disabled and can be re-imaged or whatever you need to do. Once you are done, I can re-enable it and watch its first build. [1] http://buildbot-master83.bb.releng.scl3.mozilla.com:8101/builders/WINNT%205.2%20try%20leak%20test%20build/builds/2110

0019 is ready to go.

Do we have any update on what happened on 0019?

(In reply to Mark Cornmesser [:markco] from comment #80) > Do we have any update on what happened on 0019? no sorry, I was pulled away for other priorities. I'll update my staging master and trigger a build before end of day.

(In reply to Jordan Lund (:jlund) from comment #81) > (In reply to Mark Cornmesser [:markco] from comment #80) > > Do we have any update on what happened on 0019? > > no sorry, I was pulled away for other priorities. I'll update my staging > master and trigger a build before end of day. ugh, I had a fix in my staging master from last week that I thought would help but I don't think it was the cause. Back to original plan of having to throw it into production. I have just enabled it into try. I'll keep an eye on it so it doesn't burn jobs all night.

first few jobs were fine last night and today continues green: http://buildbot-master87.bb.releng.scl3.mozilla.com:8101/buildslaves/b-2008-ix-0019 this concludes that however we install 3.0b1 on the machine, it doesn't screw up the build when using 2.46u (like it was in staging https://bugzilla.mozilla.org/show_bug.cgi?id=989531#c75). To test if 3.0b1 itself works, we need to add 3.0b1 to the path. I'll create a patch for that now. I think it's safe to land for machines that don't have 3.0b1 installed on it as we will just revert to 2.46u

coop, I'm expecting this and the last patch to be a no-op for all our builds but to trigger a 3.0b1 based build on 0019 (the one try machine that has 3 b1 installed)

one of these was supposed to be for bbot-cfgs

Comment on attachment 8590068 [details] [diff] [review] 150408_bug_989531_nsis-adds_3b1-mh.patch on production. needs mh json bump (patch incoming) to land on central: http://hg.mozilla.org/build/mozharness/rev/ed7cbf080ee6

Comment on attachment 8590068 [details] [diff] [review] 150408_bug_989531_nsis-adds_3b1-mh.patch on m-c and related try pushes from now on: https://hg.mozilla.org/mozilla-central/rev/459352500f98

Comment on attachment 8592345 [details] [diff] [review] 150408_bug_989531_nsis-adds_3b1-bbot-cfgs.patch thanks, on default: https://hg.mozilla.org/build/buildbot-configs/rev/96b822c48c55

so far the try runs on 0019[1] have not been based off a central REV newer than https://hg.mozilla.org/mozilla-central/rev/459352500f98 iow - 3.0b1 has not been tested yet [1] https://secure.pub.build.mozilla.org/builddata/reports/slave_health/slave.html?name=b-2008-ix-0019

In production: https://hg.mozilla.org/build/buildbot-configs/rev/96b822c48c55

(In reply to Jordan Lund (:jlund) from comment #90) > so far the try runs on 0019[1] have not been based off a central REV newer > than https://hg.mozilla.org/mozilla-central/rev/459352500f98 > > iow - 3.0b1 has not been tested yet > > [1] > https://secure.pub.build.mozilla.org/builddata/reports/slave_health/slave. > html?name=b-2008-ix-0019 looking good: https://secure.pub.build.mozilla.org/builddata/reports/slave_health/slave.html?name=b-2008-ix-0019 I can see a win32 and win64 seeing and using 3.0b1. rstrong, can you confirm these logs look sane: https://treeherder.mozilla.org/logviewer.html#?job_id=6661736&repo=try https://treeherder.mozilla.org/logviewer.html#?job_id=6671843&repo=try If it all looks well, we can roll this out across our builders

The logs look great!

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #93) > The logs look great! great. markco, we are okay to proceed with rolling this out (updating windows builders to mach 0019). Shall we do it in chunks of 10? Let me know if you require releng assistance in disabling/verifying/enabling. note: I'd imagine this will require a change in GPO, puppet, and windows ec2 AMI as relops puppet and AWS efforts may need to be updated to reflect this too.

Instead of trying to modify small chunks of mozillabuild and then having to rebase (with potential odd side effects of having different partial packages installed), we're tracking mozillabuild. As soon as mozillabuild includes the new version of NSIS, we'll roll out a new moznillabuild.

Ryan, approximately when will the next release of MozillaBuild happen?

I'm triaging the last few open bugs for it now. Hoping to get a final test build up this week and a final release next week if no major issues are found.

Thanks!

fyi - I am on PTO until May 13th. If we are ready for roll-out prior to that date and we need releng assistance, please ask arr or coop to triage.

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #97) > I'm triaging the last few open bugs for it now. Hoping to get a final test > build up this week and a final release next week if no major issues are > found. Ryan, any update?

I posted a release candidate build today. Barring any last-second issues, this is the build that will be shipped as the final release: http://people.mozilla.org/~rvandermeulen/MozillaBuildSetup2.0.0RC1.exe

Yay and thanks!

MozillaBuild 2.0 has been released so NSIS 3.0b1 can be deployed to the buildslaves http://ftp.mozilla.org/pub/mozilla.org/mozilla/libraries/win32/MozillaBuildSetup-Latest.exe Are there any other things that need to be done besides deployment?

There will be a discussion tomorrow morning in regards to deploying the new version of nsis and possible impacts.

bug 1173468 (use tooltool for nsis) is probably a better solution long-term than system-wide deployments.

For the Puppet machines I am going to upgrade the MozillaBuild package to version 2.0(the package that has python 2.7.6 rolled in), and test it with in the Puppet Try test pool. For the domain managed machines, it will be a new GPO. kmoir: Is there a few 2008 machines I could use to test?

Do you mean you want loaner machines to test in staging or machines to run this on in production?

A few try machines would probably be good for this.

Above comment.

Some time has passed on this and I forgot that we already did the majority of the work on this. NSIS 3.01b has been on b-2008-ix-0019 for a while now, and it has been active in production. kmoir: and ryanvm: How do you guys feel about deploying it pool wide? Instead of doing additional tests? If we are a go, I will deploy it and get all the associated machines back into production (I found some machines that were set aside for this for the original testing).

Fine with me.

Fine with me. So you don't need the slaves I just loaned you this morning?

Nope. My bad. Sorry for the inconvenience. I will get everything back into production.

I am not deploying the GPO to the builder OU.

Correction now deploying.

Package has been deployed. Loaned machines have been returned to production.