Closed
Bug 1145909
Opened 10 years ago
Closed 10 years ago
Use an image instead of toolbarbutton for the reading list button
Categories
(Firefox :: Theme, defect, P5)
Firefox
Theme
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox38 | --- | fixed |
People
(Reporter: jaws, Assigned: jaws)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1140345 +++
The reader mode button in the location bar is too close to the dropdown arrow as well as adjacent location bar icons when there are any.
This could be fixed by addressing bug 1140340 and reverting most of bug 1131458.
|
Assignee | |
Updated•10 years ago
|
Flags: qe-verify-
Flags: firefox-backlog+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: regression
|
|
Assignee | |
Updated•10 years ago
|
Summary: Use an image instead of toolbarbutton for the reading view button → Use an image instead of toolbarbutton for the reading list button
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8581003 -
Flags: review?(florian)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8581003 [details] [diff] [review]
Patch
Review of attachment 8581003 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/themes/shared/readinglist/readinglist.inc.css
@@ +8,2 @@
> list-style-image: url("chrome://browser/skin/readinglist/icons.svg#addpage");
> + -moz-image-region: rect(0,14px,14px,0);
nit: add a space after each comma.
Attachment #8581003 -
Flags: review?(florian) → review+
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8581003 [details] [diff] [review]
Patch
Review of attachment 8581003 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/base/content/browser.xul
@@ +829,5 @@
> onclick="gPopupBlockerObserver.onReportButtonClick(event);"/>
> + <image id="readinglist-addremove-button"
> + class="urlbar-icon"
> + hidden="true"
> + oncommand="ReadingListUI.togglePageByBrowser(gBrowser.selectedBrowser);"/>
This oncommand needs to be changed to onclick.
|
|
||
Comment 4•10 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
||
Updated•10 years ago
|
Iteration: 38.3 - 23 Feb → 39.2 - 23 Mar
|
||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
|
|
Assignee | |
Comment 6•10 years ago
|
||
status-firefox38:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•