Closed
Bug 1150175
Opened 10 years ago
Closed 10 years ago
Remove --test-manifest mochitest option from mozharness scripts and configs
Categories
(Release Engineering :: Applications: MozharnessCore, defect)
Release Engineering
Applications: MozharnessCore
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ahal, Assigned: ahal)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 2 obsolete files)
The --test-manifest and --run-only-tests options have been removed from mochitest. They still exist in a few places in mozharness:
https://dxr.mozilla.org/build:mozharness/search?q=%22--test-manifest%22&case=true&redirect=true
This is actually blocking bug 1147129 because this line adds a '' in the arguments which trips up argparse (but which optparse silently gobbled up):
https://dxr.mozilla.org/mozilla-central/source/testing/config/mozharness/b2g_emulator_config.py#68
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
/r/6501 - Bug 1150175 - Remove references to deprecated --test-manifest in mozharness, r=chmanchester
Pull down this commit:
hg pull -r 7efa5df8847b3138ffdf08e50c93419991da1573 https://reviewboard-hg.mozilla.org/build-mozharness
Attachment #8586985 -
Flags: review?(cmanchester)
Assignee | ||
Comment 3•10 years ago
|
||
/r/6505 - Bug 1150175 - Remove obsoleted %(test_manifest)s config options from b2g mochitests, r=chmanchester
Pull down this commit:
hg pull -r b8cbe02f46adc3711fc12cf34a94bdf65bddbd22 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8586987 -
Flags: review?(cmanchester)
Assignee | ||
Comment 4•10 years ago
|
||
First patch is mozharness, second is m-c. Here's a try run with the two of them in action:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f3ef8efd117
Comment 5•10 years ago
|
||
Comment on attachment 8586985 [details]
MozReview Request: bz://1150175/ahal
https://reviewboard.mozilla.org/r/6499/#review5431
Ship It!
::: scripts/b2g_desktop_unittest.py
(Diff revision 1)
> if not self.test_manifest:
> if suite == 'mochitest':
> - self.test_manifest = 'b2g-desktop.json'
> + self.test_manifest = None
Can we skip this condition altogether now?
::: scripts/b2g_emulator_unittest.py
(Diff revision 1)
> if not self.test_manifest:
> if suite == 'mochitest':
> - self.test_manifest = 'b2g.json'
> + self.test_manifest = None
Same here, if self.test_manifest is already falsy maybe ditch this condition.
Attachment #8586985 -
Flags: review?(cmanchester) → review+
Comment 6•10 years ago
|
||
Comment on attachment 8586987 [details]
MozReview Request: bz://1150175/ahal
https://reviewboard.mozilla.org/r/6503/#review5433
Ship It!
Attachment #8586987 -
Flags: review?(cmanchester) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8586985 [details]
MozReview Request: bz://1150175/ahal
/r/6501 - Bug 1150175 - Remove references to deprecated --test-manifest in mozharness, r=chmanchester
Pull down this commit:
hg pull -r 95bd5f6fe1244a012346c0e2d67eab94632e774a https://reviewboard-hg.mozilla.org/build-mozharness
Attachment #8586985 -
Flags: review+
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8586985 [details]
MozReview Request: bz://1150175/ahal
Fix comment, carry r+ forward.
Attachment #8586985 -
Flags: review+
Assignee | ||
Comment 9•10 years ago
|
||
Assignee | ||
Comment 10•10 years ago
|
||
The m-c patch is safe to land first. I'll land the mozharness one once that gets merged.
Whiteboard: [leave-open]
Comment 11•10 years ago
|
||
Assignee | ||
Comment 12•10 years ago
|
||
Here's a try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c490f8b66328
Landed:
https://hg.mozilla.org/build/mozharness/rev/9c57c25cca57
Whiteboard: [leave-open]
Assignee | ||
Updated•10 years ago
|
Attachment #8586987 -
Flags: checked-in+
Assignee | ||
Updated•10 years ago
|
Attachment #8586985 -
Flags: checked-in+
Comment 13•10 years ago
|
||
mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/production
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 14•9 years ago
|
||
Attachment #8586985 -
Attachment is obsolete: true
Attachment #8586987 -
Attachment is obsolete: true
Attachment #8619948 -
Flags: review+
Attachment #8619949 -
Flags: review+
Assignee | ||
Comment 15•9 years ago
|
||
Assignee | ||
Comment 16•9 years ago
|
||
Assignee | ||
Comment 17•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•