Closed
Bug 1151487
Opened 10 years ago
Closed 10 years ago
Enable software vsync compositor on Fennec
Categories
(Core :: Graphics, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: mchang, Assigned: mchang)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
Enable the software vsync compositor on fennec
Assignee | ||
Comment 1•10 years ago
|
||
Looks good on try I think - https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc28bfbc075e
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8589278 -
Flags: review?(bugmail.mozilla)
Comment 3•10 years ago
|
||
Comment on attachment 8589278 [details] [diff] [review]
Enable software vsync compositor on fennec
Review of attachment 8589278 [details] [diff] [review]:
-----------------------------------------------------------------
::: modules/libpref/init/all.js
@@ +4665,5 @@
> pref("gfx.vsync.compositor", true);
> pref("gfx.vsync.refreshdriver", true);
> #endif
>
> +#if defined(ANDROID)
use MOZ_WIDGET_ANDROID. ANDROID includes B2G which is not what you want here
Attachment #8589278 -
Flags: review?(bugmail.mozilla) → review+
Comment 4•10 years ago
|
||
Comment on attachment 8589278 [details] [diff] [review]
Enable software vsync compositor on fennec
Review of attachment 8589278 [details] [diff] [review]:
-----------------------------------------------------------------
Actually.. probably better to just put it in mobile/android/app/mobile.js
Assignee | ||
Comment 5•10 years ago
|
||
Moved to mobile/android/app/mobile.js
Looks like I don't need any ifdefs for android right?
Attachment #8589278 -
Attachment is obsolete: true
Attachment #8589385 -
Flags: review?(bugmail.mozilla)
Comment 6•10 years ago
|
||
Comment on attachment 8589385 [details] [diff] [review]
Enable software vsync compositor on fennec
Review of attachment 8589385 [details] [diff] [review]:
-----------------------------------------------------------------
Yup this looks good.
Attachment #8589385 -
Flags: review?(bugmail.mozilla) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Comment 8•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•