Closed
Bug 1071275
Opened 10 years ago
Closed 10 years ago
[meta] Enable Silk on Other platforms
Categories
(Firefox OS Graveyard :: Performance, defect, P2)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
2.2 S11 (1may)
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: mchang, Assigned: mchang)
References
()
Details
(Whiteboard: [games:p2][platform-rel-Games])
Attachments
(1 file)
(deleted),
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
Once we get silk working on b2g, let's align the refresh driver / compositor / input across the other platforms.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → mchang
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
Vsync compositor on OS X passing try - https://treeherder.mozilla.org/#/jobs?repo=try&revision=561f7c233885
Assignee | ||
Comment 3•10 years ago
|
||
Try looks good on OS X + Windows with all of Silk enabled - https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa339e4699fd
Comment 4•10 years ago
|
||
Is there a bug filed for graphical corruption/artifacts after enabling vsync?
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Johannes Pfrang [:johnp] from comment #4)
> Is there a bug filed for graphical corruption/artifacts after enabling vsync?
Not at the moment, but you can file one as a dependent of this bug. What are you seeing?
You can also always disable it by setting these prefs to false on b2g:
gfx.vsync.hw-vsync.enabled
gfx.vsync.compositor
gfx.touch.resample
Assignee | ||
Comment 7•10 years ago
|
||
Once bug 1151488 lands, silk will be on everywhere. Hardware vsync on b2g kit-kat, Windows w/ DWM, and OS X. Software vsync everywhere else. Consolidate all the preferences into one place.
Attachment #8590884 -
Flags: review?(bugmail.mozilla)
Comment 8•10 years ago
|
||
Comment on attachment 8590884 [details] [diff] [review]
Consoildate silk preferences
Review of attachment 8590884 [details] [diff] [review]:
-----------------------------------------------------------------
::: modules/libpref/init/all.js
@@ +4666,5 @@
> #endif
>
> // Use vsync aligned rendering. b2g prefs are in b2g.js.
> // Hardware vsync supported on windows, os x, and b2g.
> // Linux and fennec will use software vsync.
I think just remove this entire comment block except for the first sentence. The rest of it may easily go out of date since people fiddling in other parts of the code may not update this. (The bits about b2g are already wrong/incomplete)
Attachment #8590884 -
Flags: review?(bugmail.mozilla) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S11 (1may)
Whiteboard: [games:p2]
Updated•8 years ago
|
Whiteboard: [games:p2] → [games:p2][platform-rel-Games]
You need to log in
before you can comment on or make changes to this bug.
Description
•