Closed
Bug 1152666
Opened 10 years ago
Closed 10 years ago
[System] JSHint for group 3: telephony related
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: johnhu, Assigned: johnhu)
References
Details
Attachments
(1 file)
files:
apps/system/js/emergency_callback_manager.js
apps/system/js/icc_events.js
apps/system/js/sim_lock.js
If they have test case, please fix them at the same time.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → im
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8590111 [details]
[gaia] huchengtw-moz:bug-1152666-jshint-telephony > mozilla-b2g:master
This patch fixes jshint errors/warnings for telephony related files. Please review this patch. Thanks.
Attachment #8590111 -
Flags: review?(alive)
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8590111 [details]
[gaia] huchengtw-moz:bug-1152666-jshint-telephony > mozilla-b2g:master
remove review flag because of test cases failed.
Attachment #8590111 -
Flags: review?(alive)
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8590111 [details]
[gaia] huchengtw-moz:bug-1152666-jshint-telephony > mozilla-b2g:master
This patch fixes jshint errors/warnings. Please review this patch.
Attachment #8590111 -
Flags: review?(alive)
Updated•10 years ago
|
Attachment #8590111 -
Flags: review?(alive) → review?(gduan)
Comment 5•10 years ago
|
||
Comment on attachment 8590111 [details]
[gaia] huchengtw-moz:bug-1152666-jshint-telephony > mozilla-b2g:master
r=gduan
Attachment #8590111 -
Flags: review?(gduan) → review+
Assignee | ||
Comment 6•10 years ago
|
||
merged to master:
https://github.com/mozilla-b2g/gaia/commit/68bc942912c5da7974c8220e8824355db3848d9c
tree herder is all green:
https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=eba2233d73780903bb8549796f3a47209fa37cda
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•