Closed
Bug 996423
(system-jshint)
Opened 11 years ago
Closed 9 years ago
[meta] JSHint fixes for System app.
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evanxd, Unassigned)
References
Details
We should do JSHint fixes for the files listed at https://github.com/mozilla-b2g/gaia/blob/master/build/jshint/xfail.list#L435-L641. There are 207 files needed to fix.
Reporter | ||
Comment 1•11 years ago
|
||
We could list files had good test coverage here, and let contributors to fix them.
Reporter | ||
Comment 2•11 years ago
|
||
There are students would like to help this.
Comment 3•10 years ago
|
||
I think that this would be better to do as we land the v2 system refactor in order to streamline review time. Going to go ahead and block bug 1084191 which is tracking our remaining JSHint fixes.
Blocks: 1084191
Comment 4•10 years ago
|
||
I am willing to pick this bug and send the patches since I've worked on most of the jshint bugs so far. Should I fix all of them in one single patch ? or break them down into ?
- apps/system/js/*
- apps/system/test/marionette/*
- apps/system/test/unit/*
Flags: needinfo?(kgrandon)
Flags: needinfo?(evanxd)
Comment 5•10 years ago
|
||
This seems to have sit for a while so if you want to start working through it that would be great!
Some of the files in the system app are quite large. I would recommend grouping them by folder where possible, or doing chunks of a few files at a time. You could also break them down into smaller groups if you wanted, e.g., apps/system/test/unit/mock_*, and apps/system/test/unit/fxa*
Flags: needinfo?(kgrandon)
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(evanxd)
Updated•10 years ago
|
Blocks: tv-system-merge
Comment 7•10 years ago
|
||
The plan for this issue is at:
https://gist.github.com/shamenchens/27192af45c5225946fe8#file-todo-list
We found:
1. jshint error/warning
2. some files had been removed but still in build/jshint/xfail.list
We will try to fix all of them.
Updated•10 years ago
|
Alias: system-jshint
Comment 8•10 years ago
|
||
Phase 1 is all finished. We are waiting for the landing of bug 1094759 to start phase 2.
Depends on: system-bootstrap
Comment 9•9 years ago
|
||
close it \o/
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•