Closed
Bug 1153574
Opened 10 years ago
Closed 10 years ago
Re-enable Mulet reftests taskcluster-specific disables.
Categories
(Firefox OS Graveyard :: Runtime, defect)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
2.2 S11 (1may)
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file, 10 obsolete files)
(deleted),
patch
|
gerard-majax
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1144079 +++
As of bug 1144079 comment 12, it looks like we can re-enable most of the reftest
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4046e034126
https://treeherder.allizom.org/#/jobs?repo=try&revision=c4046e034126
This should re-enable hundred of reftests and still be green.
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Alexandre LISSY :gerard-majax from comment #2)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4046e034126
> https://treeherder.allizom.org/#/jobs?repo=try&revision=c4046e034126
>
> This should re-enable hundred of reftests and still be green.
And of course, we expect a couple of failures on R3, R4, R5 and R6 as in bug 1144079 comment 12.
Assignee | ||
Comment 4•10 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=22c26e0d14cd
https://treeherder.allizom.org/#/jobs?repo=try&revision=22c26e0d14cd
And that should bring us back to all mochitest being green and all reftest being green.
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8591262 -
Flags: review?(ahalberstadt)
Assignee | ||
Comment 6•10 years ago
|
||
Attachment #8591263 -
Flags: review?(ahalberstadt)
Assignee | ||
Comment 7•10 years ago
|
||
Attachment #8591264 -
Flags: review?(ahalberstadt)
Assignee | ||
Comment 8•10 years ago
|
||
Attachment #8591265 -
Flags: review?(ahalberstadt)
Assignee | ||
Comment 9•10 years ago
|
||
Attachment #8591255 -
Attachment is obsolete: true
Attachment #8591266 -
Flags: review?(ahalberstadt)
Assignee | ||
Comment 10•10 years ago
|
||
Attachment #8591263 -
Attachment is obsolete: true
Attachment #8591263 -
Flags: review?(ahalberstadt)
Attachment #8591268 -
Flags: review?(ahalberstadt)
Assignee | ||
Comment 11•10 years ago
|
||
Attachment #8591265 -
Attachment is obsolete: true
Attachment #8591265 -
Flags: review?(ahalberstadt)
Attachment #8591269 -
Flags: review?(ahalberstadt)
Assignee | ||
Comment 12•10 years ago
|
||
(In reply to Alexandre LISSY :gerard-majax from comment #4)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=22c26e0d14cd
> https://treeherder.allizom.org/#/jobs?repo=try&revision=22c26e0d14cd
>
> And that should bring us back to all mochitest being green and all reftest
> being green.
Small typos on R4 and R6.
Assignee | ||
Comment 13•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 14•10 years ago
|
||
(In reply to Alexandre LISSY :gerard-majax from comment #13)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b88ceeb4523
> https://treeherder.allizom.org/#/jobs?repo=try&revision=6b88ceeb4523
Stable after lots of retriggers. The only failures are either bug 1140394 or bug 1153584.
Assignee | ||
Updated•10 years ago
|
Summary: Re-enable Mulet mochitests and reftests taskcluster-specific disables. → Re-enable Mulet reftests taskcluster-specific disables.
Assignee | ||
Comment 15•10 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=737d6de2d8ee
https://treeherder.allizom.org/#/jobs?repo=try&revision=737d6de2d8ee
This includes a tentative fix for bug 1140394 making use of threading.Lock() to protect stdout from interleaving.
Assignee | ||
Comment 16•10 years ago
|
||
Using sys.stdout.write():
https://treeherder.allizom.org/#/jobs?repo=try&revision=dde031e66745
Using sys.stdout.write() and sys.stdout.flush():
https://treeherder.allizom.org/#/jobs?repo=try&revision=0b9f05b77f54
From those two, it looks like we can mitigate/eliminate bug 1140394 by the use of sys.stdout.write() followed by sys.stdout.flush().
That's exposing a new low-rate intermittent in R4, btw.
Assignee | ||
Comment 17•10 years ago
|
||
Looks like the intermittent is already known: bug 1101424 "Intermittent background-zoom-2.html | image comparison (==), max difference: 16, number of differing pixels: 11"
Assignee | ||
Comment 18•10 years ago
|
||
Attachment #8591268 -
Attachment is obsolete: true
Attachment #8591268 -
Flags: review?(ahalberstadt)
Attachment #8591402 -
Flags: review?(ahalberstadt)
Assignee | ||
Comment 19•10 years ago
|
||
Added fuzzy-if() for R4 intermittents:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d65013d65a1
https://treeherder.allizom.org/#/jobs?repo=try&revision=8d65013d65a1
Updated•10 years ago
|
Attachment #8591262 -
Flags: review?(ahalberstadt) → review+
Updated•10 years ago
|
Attachment #8591264 -
Flags: review?(ahalberstadt) → review+
Updated•10 years ago
|
Attachment #8591266 -
Flags: review?(ahalberstadt) → review+
Updated•10 years ago
|
Attachment #8591269 -
Flags: review?(ahalberstadt) → review+
Updated•10 years ago
|
Attachment #8591402 -
Flags: review?(ahalberstadt) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 20•10 years ago
|
||
Rebasing on current master
Attachment #8591266 -
Attachment is obsolete: true
Assignee | ||
Comment 21•10 years ago
|
||
Comment on attachment 8591696 [details] [diff] [review]
Re-enable Mulet reftests taskcluster-specific disables.
Carrying r+, updated layout/reftests/position-dynamic-changes/relative/reftest.list after bug 742176
Attachment #8591696 -
Flags: review+
Comment 22•10 years ago
|
||
Comment on attachment 8591262 [details] [diff] [review]
Disable some reftest on Mulet for R3 green
This already landed as part of bug 1144080 if I'm not mistaken.
Attachment #8591262 -
Attachment is obsolete: true
Comment 23•10 years ago
|
||
Comment on attachment 8591264 [details] [diff] [review]
Disable some reftest on Mulet for R5 green
Likewise.
Attachment #8591264 -
Attachment is obsolete: true
Comment 24•10 years ago
|
||
0 for 2 now in this bug for having applicable patches. Please verify what actually needs to land still and re-request checkin.
Keywords: checkin-needed
Assignee | ||
Comment 25•10 years ago
|
||
Ryan, sorry, I should have made it more obvious, but those actually gets re-enabled in attachment 8591696 [details] [diff] [review].
Assignee | ||
Comment 26•10 years ago
|
||
Merging all in one patch
Attachment #8591269 -
Attachment is obsolete: true
Attachment #8591402 -
Attachment is obsolete: true
Attachment #8591696 -
Attachment is obsolete: true
Attachment #8591922 -
Flags: review+
Assignee | ||
Comment 27•10 years ago
|
||
attachment 8591922 [details] [diff] [review] is the merge of all the patches.
Flags: needinfo?(ryanvm)
Keywords: checkin-needed
Comment 28•10 years ago
|
||
Flags: needinfo?(ryanvm)
Keywords: checkin-needed
Comment 29•10 years ago
|
||
Updated•10 years ago
|
Target Milestone: --- → 2.2 S11 (1may)
You need to log in
before you can comment on or make changes to this bug.
Description
•