Changes: #2139 Adds scoring to the swfm player. #2140 Render in requestAnimationFrame during scoring. #2142 Addresses review https://bugzilla.mozilla.org/show_bug.cgi?id=1148382#c3 #2143 Sanitizing timeline scenes #2141 Update README.md #2034 Video players test suite #2113 Setup test harness and automate parse and playback tests #2144 Remove ActivationQueue in the extension. #2146 Bug 1137947 - Addresses review comments

Comment on attachment 8592831 [details] [diff] [review] Update Shumway to version 0.10.344 Review of attachment 8592831 [details] [diff] [review]: ----------------------------------------------------------------- r=me with comments addressed. ::: browser/extensions/shumway/chrome/ExternalInterface.jsm @@ +54,4 @@ > > + initExternalCom: function (window, embedTag, onExternalCallback) { > + var traceExternalInterface = getBoolPref('shumway.externalInterface.trace', false); > + // Initialize convenience functions. Notice that these functions can be s/can be/are/ ::: browser/extensions/shumway/chrome/ShumwayCom.jsm @@ +158,5 @@ > // window to the primary one. > function postSyncMessage(msg) { > if (onSyncMessageCallback) { > // the msg came from other content window > + // waiveXrays are used due to bug 1150771. That bug is fixed now. File a bug about removing this once the fix has reached beta? @@ +558,5 @@ > return; > > // TODO check more security stuff ? > if (!this.externalInterface) { > + var parentWindow = this.window.parent; // hosted page -- parent of PlayPreview frame s/hosted/host/ ::: browser/extensions/shumway/content/ShumwayStreamConverter.jsm @@ +294,2 @@ > var parsedPageUrl = Services.io.newURI(pageUrl); > + // ... it can specified as a relative URL. I don't understand this comment. I think I do understand what the code does and why, but not the comment. Please make it more explicit by saying what it attempted here, and why it's ok to ignore exceptions. @@ +440,5 @@ > switch (variable) { > case '$version': > return 'SHUMWAY 10,0,0'; > default: > + log('Not supported GetVariable() call: ' + variable); s/Not /Un/

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f9dd6678e6e https://github.com/mozilla/shumway/pull/2153