Closed
Bug 1148382
Opened 10 years ago
Closed 10 years ago
Update Shumway to version 0.10.312
Categories
(Firefox Graveyard :: Shumway, defect)
Firefox Graveyard
Shumway
Tracking
(firefox40 fixed)
RESOLVED
FIXED
Firefox 40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: yury, Assigned: yury)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
Changes:
#2120 Don't restart AS2 sound if playing.
#2123 Bug 1089930 - intermittent issue in loader, "TypeError: f._addFrame is not a function"
#2126 Misc text fixes
#2127 Bug 1111743 - Annotate Shumway functions to be inlined
#2128 Fixes caching of the ActionsData
#2117 Use more efficient string concatenation in base64ArrayBuffer().
#2121 Escape string
#2129 Fix regression in #2125
#2130 Bug 1145499 - Removes enablePrivilege usage.
#2132 Bug 1143487 - Disabling external interface if processExternalCommand is not specified.
#2133 Bug 1136470 - Protect from double components registration.
#2134 Stubs GetVersion('$version') call.
#2135 Adds swfdec link for botio swfdec testing.
#2136 Very simplified botio command runner.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8584473 -
Flags: review?(till)
Assignee | ||
Comment 2•10 years ago
|
||
Adding few more commits (related PRs were already mentioned in comment 0)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b2f4a1304ba2
Attachment #8584473 -
Attachment is obsolete: true
Attachment #8584473 -
Flags: review?(till)
Attachment #8584517 -
Flags: review?(till)
Assignee | ||
Updated•10 years ago
|
Summary: Update Shumway to version 0.10.307 → Update Shumway to version 0.10.312
Comment 3•10 years ago
|
||
Comment on attachment 8584517 [details] [diff] [review]
Update Shumway to version 0.10.312
Review of attachment 8584517 [details] [diff] [review]:
-----------------------------------------------------------------
Nice. r=me as-is, but please either fix or at least file bugs for the comments so we don't completely forget about them.
::: browser/extensions/shumway/content/ShumwayStreamConverter.jsm
@@ +396,2 @@
> if (objectParams.base) {
> + try {
We should have a comment explaining what this does and why it's ok to just ignore failures and continue on with the non-changed baseUrl.
@@ +553,5 @@
> + switch (variable) {
> + case '$version':
> + return 'SHUMWAY 10,0,0';
> + default:
> + log('GetVariable: ' + variable);
Please make this comment slightly more verbose. If it is actually triggered in the wild, say, a few months from now, we probably won't remember what this means.
Attachment #8584517 -
Flags: review?(till) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•10 years ago
|
See Also: → https://github.com/mozilla/shumway/issues/2142
Comment 4•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•