Closed
Bug 1154776
Opened 10 years ago
Closed 10 years ago
nsTransitionManager.h:44:44: error: 'AsTransition' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 1004383
Tracking | Status | |
---|---|---|
firefox40 | --- | affected |
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
New clang >3.6 build warning (treated as error for warnings-as-error builds):
{
nsTransitionManager.h:44:44: error: 'AsTransition' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
}
This function was added in this cset:
http://hg.mozilla.org/mozilla-central/rev/5177486bb831
and was missing the 'override' keyword.
Assignee | ||
Comment 1•10 years ago
|
||
Landing a fix shortly, with blanket r+ that ehsan granted me for fixes of this sort over in bug 1126447 comment 2.
(I hit several other build errors of the same sort, in other parts of the tree, and I'm prepping commits to fix all of them in a single push.)
Assignee | ||
Comment 2•10 years ago
|
||
Looks like ehsan already fixed this on inbound, actually. (in https://hg.mozilla.org/integration/mozilla-inbound/rev/c20a148abbb0 )
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
Assignee | ||
Comment 3•10 years ago
|
||
duping back to the original bug 1004383, since that's the bug number in ehsan's commit.
Resolution: WORKSFORME → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•