Closed
Bug 1156143
Opened 10 years ago
Closed 10 years ago
[Stingray][Home] Allow user to move cards out of a folder
Categories
(Firefox OS Graveyard :: Gaia::TV::Home, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: yifan, Assigned: yifan)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(2 files)
+++ This bug was initially created as a clone of Bug #1117699 +++
In edit mode, allow user to move cards out of a folder to the main list.
This is a follow-up bug from bug 1117699.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → yliao
|
|
Assignee | |
Comment 1•10 years ago
|
||
Hi Rex, please help review these 3 commits for dragging a card out of a folder. Thanks!
Attachment #8600808 -
Flags: review?(rexboy)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8600808 [details]
review only patch
Looks good to me with some comments. Please make modify on them, squash commits and modify commit messages before landing.
If you have questions on comments just talk to me. Thanks!
Attachment #8600808 -
Flags: review?(rexboy) → review+
|
||
Comment 3•10 years ago
|
||
|
|
Assignee | |
Comment 4•10 years ago
|
||
Comment on attachment 8601304 [details]
[gaia] begeeben:1156143_allow_user_to_move_cards_out_of > mozilla-b2g:master
Thanks for the review! Here is the modified pull request. Please see if there's refinements needed.
Attachment #8601304 -
Flags: review?(rexboy)
|
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8601304 [details]
[gaia] begeeben:1156143_allow_user_to_move_cards_out_of > mozilla-b2g:master
Still two places before landing. Ping me if you are uncertain on my comments.
Attachment #8601304 -
Flags: review?(rexboy) → review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
Thanks for the review! Merged into master:
https://github.com/mozilla-b2g/gaia/pull/29877
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
||
Updated•9 years ago
|
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-cherry-pick]
|
||
Updated•9 years ago
|
Whiteboard: [ft:conndevices][partner-cherry-pick] → [ft:conndevices]
You need to log in
before you can comment on or make changes to this bug.
Description
•