Closed
Bug 1156635
Opened 10 years ago
Closed 9 years ago
[Stingray][Contribution] Browser
Categories
(Firefox OS Graveyard :: Gaia::TV, defect, P1)
Firefox OS Graveyard
Gaia::TV
Tracking
(feature-b2g:2.5+)
People
(Reporter: howie, Assigned: yifan)
References
Details
(Whiteboard: [ft:conndevices][partner-blocker])
Attachments
(1 file)
Stingray browser contribution
Reporter | ||
Updated•10 years ago
|
Priority: -- → P1
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 1•9 years ago
|
||
Should remove proprietary API and functionality from the contributed code.
Updated•9 years ago
|
Status: NEW → ASSIGNED
Updated•9 years ago
|
feature-b2g: --- → 2.5+
Comment 2•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8648660 [details]
[gaia] begeeben:1156635_browser > mozilla-b2g:master
Please help review the partner contribution, thanks!
Please refer to https://github.com/begeeben/gaia/commits/tv_browser if detailed commit logs are needed.
Attachment #8648660 -
Flags: review?(rexboy)
Updated•9 years ago
|
Target Milestone: --- → FxOS-S6 (04Sep)
Comment 4•9 years ago
|
||
Comment on attachment 8648660 [details]
[gaia] begeeben:1156635_browser > mozilla-b2g:master
First, thanks for your effort to adapt these codes!
We have some issues that need to be take care. Please see my comments.
Attachment #8648660 -
Flags: review?(rexboy)
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8648660 [details]
[gaia] begeeben:1156635_browser > mozilla-b2g:master
Thanks for the detailed review and notes! Please help to review the updated code, thanks!
Attachment #8648660 -
Flags: review?(rexboy)
Comment 6•9 years ago
|
||
Comment on attachment 8648660 [details]
[gaia] begeeben:1156635_browser > mozilla-b2g:master
Thank you!
please remove the redundant brand icon inside browser app and make sure the tests are all green before landing.
Attachment #8648660 -
Flags: review?(rexboy) → review+
Updated•9 years ago
|
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-blocker]
Assignee | ||
Comment 7•9 years ago
|
||
Added Bug 1198115 - [browser] Rewrite browser_db_test.js to track test issues.
Added Bug 1198103 - [browser] Fix jshint errors to track jshint errors.
Added Bug 1196624 - Need official and unofficial 336 pixel Firefox branding icon for Firefox OS TV to track branding icon.
Added Bug 1198200 - [browser] Fix eslint errors to track eslint errors.
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8648660 [details]
[gaia] begeeben:1156635_browser > mozilla-b2g:master
Thanks Rex, I've separated the commit for the eslint errors. Will be rebased into 1 commit after review granted. By Ricky's comment, it should be alright without the error details after the hash tag.
Attachment #8648660 -
Flags: review+ → review?(rexboy)
Comment 9•9 years ago
|
||
Comment on attachment 8648660 [details]
[gaia] begeeben:1156635_browser > mozilla-b2g:master
Let's add some comments to describe those files before landing, see my comment.
Attachment #8648660 -
Flags: review?(rexboy) → review+
Assignee | ||
Comment 10•9 years ago
|
||
Thanks Rex! Merged into master:
https://github.com/mozilla-b2g/gaia/pull/31371
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 11•9 years ago
|
||
Hey guys, this code is using deprecated mozL10n.get API and will require a refactor. Can we make sure that our partners know that and stop using that API please?
Comment 12•9 years ago
|
||
The total number of calls to mozL10n.get in tv_apps/browser is 40.
I annotated them in the pull request and suggested fixes. :yifan, how do you want to handle that?
Flags: needinfo?(yliao)
Assignee | ||
Comment 13•9 years ago
|
||
Thank you Zibi! May I open a follow up bug to refactor mozL10n.get? Since we have many features depending on this bug, we would like to track the issue in another bug so that we could all work in parallel.
Flags: needinfo?(yliao) → needinfo?(gandalf)
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 15•9 years ago
|
||
Thank you Zibi! We'll work on it in bug 1200078.
You need to log in
before you can comment on or make changes to this bug.
Description
•