Closed
Bug 1200078
Opened 9 years ago
Closed 9 years ago
[browser] Remove deprecated mozL10n.get
Categories
(Firefox OS Graveyard :: Gaia::TV, defect, P1)
Firefox OS Graveyard
Gaia::TV
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: yifan, Assigned: zbraniecki)
References
Details
(Whiteboard: [ft:conndevices][partner-blocker])
Attachments
(1 file)
There are 40 deprecated mozL10n.get calls in the TV browser. We should use
node.setAttribute('data-l10n-id', l10nId) or
navigator.mozL10n.setAttributes(node, l10nId, l10nArgs);
to replace them. Thanks to Zibi for the detailed comments. Please refer to the comments in https://github.com/mozilla-b2g/gaia/pull/31371 .
|
Reporter | |
Updated•9 years ago
|
|
||
Updated•9 years ago
|
Assignee: nobody → dhuang
Status: NEW → ASSIGNED
|
|
||
Comment 2•9 years ago
|
||
Hi Zibi, sorry for late update. Currently I am working on gaia-tv 2.5 feature, and the deadline is in the middle of October. So I would start fixing this bug in the end of October.
Flags: needinfo?(dhuang)
|
|
||
Updated•9 years ago
|
Status: ASSIGNED → NEW
|
||
Comment 3•9 years ago
|
||
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8712319 [details]
[gaia] zbraniecki:1200078-refactor-l10n-in-browser > mozilla-b2g:master
This quarter I'm moving System and TV to l20n, so I need this patch.
It was actually fairly trivial to write because the code is clean and easy to transition! :)
:yifan - can you review this for me?
Attachment #8712319 -
Flags: review?(yliao)
|
|
Reporter | |
Comment 5•9 years ago
|
||
Comment on attachment 8712319 [details]
[gaia] zbraniecki:1200078-refactor-l10n-in-browser > mozilla-b2g:master
Thank you for the help! Just a nit on Github.
Attachment #8712319 -
Flags: review?(yliao) → review+
|
|
Reporter | |
Updated•9 years ago
|
Assignee: dhuang → gandalf
|
|
Assignee | |
Comment 6•9 years ago
|
||
Thanks! Great catch!
Commit: https://github.com/mozilla-b2g/gaia/commit/62f6b41b8775fde10ef832fdf8c08154601ece98
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•