This object would follow the new MediaDataDemuxer API as described in bug 1154164

Remove mp4_demuxer::TrackType

Remove dependency on libstagefright's object type in mp4_demuxer objects

Add virtual destructor to TrackInfo

Add virtual getters. Allows to get rid of a static_cast

Add MP4Metadata class

Add ResourceStream object. We can't use MP4Stream as it's not really blocking and we want to get rid of the InvokeAndRetry hack. This is basically what MP4Stream used to be, with some enhancement such as pinning the underlying resource while in use

Add MoofParser::HasMetadata method. We don't want to be blocking while attempting to read the metadata with libstagefright on a partial init segment. This will allow to get rid of the ContainerParser class

Use MoofParser::HasMetadata() in the MP4Metadata to ensure we do not block attempting to read partial init segment.

remove stray header. not sure why it was ever added

Remove static_cast on TrackInfo objects.

Add Clone() and copy constructor to TrackInfo's classes.

Bad rebase.. fixed

Comment on attachment 8596359 [details] [diff] [review] Part2. Remove MP4 Index's libstagefright dependency Review of attachment 8596359 [details] [diff] [review]: ----------------------------------------------------------------- ::: media/libstagefright/binding/mp4_demuxer.cpp @@ +91,5 @@ > } > > +static void > +ConvertIndex(nsTArray<Index::Indice>& aDest, > + const stagefright::Vector<stagefright::MediaSource::Indice>& aIndex) Should return nsTArray see https://bugzilla.mozilla.org/show_bug.cgi?id=982212#c20

Comment on attachment 8596361 [details] [diff] [review] Part3. Add TrackInfo virtual destructor Review of attachment 8596361 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/media/MediaInfo.h @@ +93,5 @@ > return mType; > } > bool virtual IsValid() const = 0; > > + virtual ~TrackInfo() Is this object refcounted? If not, please add MOZ_COUNT_CTOR/DTOR.

Comment on attachment 8596363 [details] [diff] [review] Part4. Create virtual getters Review of attachment 8596363 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/media/MediaInfo.h @@ +79,5 @@ > int64_t mDuration; > int64_t mMediaTime; > CryptoTrack mCrypto; > > + virtual AudioInfo* GetAudioInfo() Maybe call these GetAs...() to imply you're not getting something from them, but rather converting their type.

Comment on attachment 8596453 [details] [diff] [review] Part11. Add TrackInfo Clone() and copy constructors Review of attachment 8596453 [details] [diff] [review]: ----------------------------------------------------------------- Are the extraData fields refcounted? If so, should you deep copy them? Or is copying its refcounted pointer sufficient?

(In reply to Anthony Jones (:kentuckyfriedtakahe, :k17e) from comment #13) > Comment on attachment 8596359 [details] [diff] [review] > Part2. Remove MP4 Index's libstagefright dependency > > Review of attachment 8596359 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: media/libstagefright/binding/mp4_demuxer.cpp > @@ +91,5 @@ > > } > > > > +static void > > +ConvertIndex(nsTArray<Index::Indice>& aDest, > > + const stagefright::Vector<stagefright::MediaSource::Indice>& aIndex) > > Should return nsTArray see > https://bugzilla.mozilla.org/show_bug.cgi?id=982212#c20 That code is removed in part5, where we want to return both a boolean and an array, I use the out parameter there.

(In reply to Chris Pearce (:cpearce) from comment #16) > Are the extraData fields refcounted? If so, should you deep copy them? Or is > copying its refcounted pointer sufficient? shallow copy is sufficient, they aren't supposed to change. I would have made them const if such possibility with ref counted objects existed.

Rename and the original intent of this bug will continue in bug 1159027

Forgot to add Stream.h to hg. https://treeherder.mozilla.org/#/jobs?repo=try&revision=95b2a37f4c41

https://hg.mozilla.org/integration/mozilla-inbound/rev/5c101c115a2f https://hg.mozilla.org/integration/mozilla-inbound/rev/5e07e2b10a78 https://hg.mozilla.org/integration/mozilla-inbound/rev/d2ed413a2048 https://hg.mozilla.org/integration/mozilla-inbound/rev/4b6149e01e96 https://hg.mozilla.org/integration/mozilla-inbound/rev/e6a5d030152c https://hg.mozilla.org/integration/mozilla-inbound/rev/cfb189bc9368 https://hg.mozilla.org/integration/mozilla-inbound/rev/d5282779b0ca https://hg.mozilla.org/integration/mozilla-inbound/rev/69d8168282fc https://hg.mozilla.org/integration/mozilla-inbound/rev/be9974876342 https://hg.mozilla.org/integration/mozilla-inbound/rev/005828e55212 https://hg.mozilla.org/integration/mozilla-inbound/rev/4b77e03a4788

https://hg.mozilla.org/mozilla-central/rev/5c101c115a2f https://hg.mozilla.org/mozilla-central/rev/5e07e2b10a78 https://hg.mozilla.org/mozilla-central/rev/d2ed413a2048 https://hg.mozilla.org/mozilla-central/rev/4b6149e01e96 https://hg.mozilla.org/mozilla-central/rev/e6a5d030152c https://hg.mozilla.org/mozilla-central/rev/cfb189bc9368 https://hg.mozilla.org/mozilla-central/rev/d5282779b0ca https://hg.mozilla.org/mozilla-central/rev/69d8168282fc https://hg.mozilla.org/mozilla-central/rev/be9974876342 https://hg.mozilla.org/mozilla-central/rev/005828e55212 https://hg.mozilla.org/mozilla-central/rev/4b77e03a4788

The TrackInfo subclasses' overrides of Clone() (from part11) and GetAsAudioInfo()/GetAsVideoInfo() (from part4) were missing the "override" keyword. This causes a build warning on clang 3.6 & newer -- see bug 1117034 -- & is treated as an error in warnings-as-errors builds. I pushed a followup to add that keyword, with blanket r+ that ehsan granted me for fixes of this sort over in bug 1126447 comment 2: https://hg.mozilla.org/integration/mozilla-inbound/rev/92f70afc7a26