Closed Bug 1158283 Opened 10 years ago Closed 8 years ago

Only derive a link to the "build directory" for buildbot jobs

Categories

(Tree Management :: Treeherder, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: armenzg, Assigned: KWierso)

References

Details

Attachments

(1 file)

STR: * Click on [1] * Click on B2G emulator L job * On the summary below to the left, click on "- b2g-emu-l" (Besides "Build:") Expected results: * The log should show up Actual results: * The log does not show up - we get this message: > {"message": "Artifact not found"} If we append "/live.log" to [3], we get re-directed to [2] [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=0231373170fe&exclusion_profile=false&filter-searchStr=B2G%20L%20Emulator%20opt%20Submitted%20by%20taskcluster%20[TC]%20B2G%20L%20Emulator%20%28Opt%29%20B [2] https://s3-us-west-2.amazonaws.com/taskcluster-public-artifacts/n0XtDuQvQB6fR651PpFFCA/0/public/logs/live_backing.log [3] https://queue.taskcluster.net/v1/task/n0XtDuQvQB6fR651PpFFCA/runs/0/artifacts/public/logs
That's not a link to the log, it's a link to the "build directory", which only works for buildbot. Click the icon in the top row of that panel for the link to the log. The UI should only show that link for buildbot jobs. That said, soon (ie once ftp.m.o goes away), even buildbot jobs won't have a buildbot directory, so this bug will likely be fixed by whatever solution is created for that.
Summary: TC job on TH does not point correctly to the log → Only derive a link to the "build directory" for buildbot jobs
Depends on: 1160410
Priority: -- → P3
Comment on attachment 8802265 [details] [treeherder] KWierso:1158283 > mozilla:master This should at least stop people from being able to click the build directory link for taskcluster jobs.
Attachment #8802265 - Flags: review?(emorley)
Comment on attachment 8802265 [details] [treeherder] KWierso:1158283 > mozilla:master Thank you for taking this - have left some comments :-)
Attachment #8802265 - Flags: review?(emorley) → review-
Assignee: nobody → wkocher
Comment on attachment 8802265 [details] [treeherder] KWierso:1158283 > mozilla:master How about this, then? Testing locally, this hides the "Build" line for taskcluster jobs but shows it for buildbot ones.
Attachment #8802265 - Flags: review- → review?(emorley)
Attachment #8802265 - Flags: review?(emorley) → review-
Comment on attachment 8802265 [details] [treeherder] KWierso:1158283 > mozilla:master So... this? :)
Attachment #8802265 - Flags: review- → review?(emorley)
Comment on attachment 8802265 [details] [treeherder] KWierso:1158283 > mozilla:master Looks good :-)
Attachment #8802265 - Flags: review?(emorley) → review+
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/21c5ced6c9d8844797065285afc11d7dccdd885a Bug 1158283 - Don't show links to build directories for taskcluster jobs (#1934) r=emorley
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: