Closed
Bug 1158750
Opened 10 years ago
Closed 10 years ago
Fix the commented out test in browser_bookmarkProperties.js
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: mak, Assigned: ttaubert)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
bug 951651 commented out a sub test, we need to fix it
|
Reporter | |
Updated•10 years ago
|
Points: --- → 2
Flags: qe-verify-
Flags: firefox-backlog+
|
Assignee | |
Comment 1•10 years ago
|
||
clickSelectsAll=false on systems other than Mac. I don't know how the test worked before but we need to call input.select() before changing the new folder's name.
|
|
Assignee | |
Updated•10 years ago
|
Iteration: --- → 40.2 - 27 Apr
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8597952 [details] [diff] [review]
0001-Bug-1158750-Reenable-browser_bookmarkProperties.js-s.patch
Well, it'd be nice to know what was going on, but it's better than commented out code.
Attachment #8597952 -
Flags: review?(mano) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
(In reply to Mano (::mano, needinfo? for any questions; not reading general bugmail) from comment #2)
> Well, it'd be nice to know what was going on, but it's better than commented
> out code.
Yeah, I agree with you. But then the test is only interested in the default button and not really in whether the text is selected. Thanks!
|
||
Updated•10 years ago
|
Iteration: 40.2 - 27 Apr → 40.3 - 11 May
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•