Closed
Bug 1071513
Opened 10 years ago
Closed 7 years ago
[meta] Enable async PlacesTransactions in Nightly
Categories
(Firefox :: Bookmarks & History, defect, P1)
Firefox
Bookmarks & History
Tracking
()
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: asaf, Assigned: standard8)
References
(Depends on 1 open bug, Blocks 3 open bugs)
Details
(Keywords: meta, perf, Whiteboard: [fxsearch])
Attachments
(1 file)
No description provided.
Updated•10 years ago
|
Updated•10 years ago
|
Summary: Enable async PlacesTransactions → Enable async PlacesTransactions in Nightly
Updated•10 years ago
|
Points: --- → 1
Flags: qe-verify-
Flags: firefox-backlog+
Updated•9 years ago
|
Priority: -- → P1
Updated•8 years ago
|
Whiteboard: [qf]
Updated•8 years ago
|
Blocks: photon-performance-triage
Updated•8 years ago
|
Points: 1 → ---
Flags: firefox-backlog+
Priority: P1 → P2
Whiteboard: [qf] → [photon-performance] [qf]
Comment 1•8 years ago
|
||
Mike, do you have information on what this can be expected to improve performance wise? It's not clear to me what the perf impact of this can be...
Flags: needinfo?(mconley)
Comment 2•8 years ago
|
||
All the bookmarks UI is currently using the old synchronous transactions for every change.
Basically, adding/removing/editing/moving one or more bookmarks go through this.
All of those operations cause main-thread I/O.
The new async transactions are expected to solve that problem (once the dependencies here are fixed), moving I/O off the main thread through the new Bookmarks API.
Updated•8 years ago
|
Whiteboard: [photon-performance] [qf] → [photon-performance] [qf:meta]
Updated•8 years ago
|
Priority: P2 → P3
Whiteboard: [photon-performance] [qf:meta] → [reserve-photon-performance] [qf:meta]
Updated•7 years ago
|
Priority: P3 → P2
Updated•7 years ago
|
Priority: P2 → P3
Whiteboard: [reserve-photon-performance] [qf:meta] → [reserve-photon-performance] [p2] [qf:meta]
Updated•7 years ago
|
Priority: P3 → P1
Whiteboard: [reserve-photon-performance] [p2] [qf:meta] → [reserve-photon-performance] [p2] [qf:meta][fxsearch]
Updated•7 years ago
|
Whiteboard: [reserve-photon-performance] [p2] [qf:meta][fxsearch] → [qf:meta][fxsearch]
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•7 years ago
|
||
Once the remaining deps are landed, I'll trigger a try build with this patch as well, and just confirm everything is still green. Then we'll land and see how it goes :-)
Assignee: nobody → standard8
Depends on: 1380599
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8886116 [details]
Bug 1071513 - Enable async PlacesTransactions for nightly builds.
https://reviewboard.mozilla.org/r/156918/#review162468
r=me once we have a green Try (may be worth retriggering all mochitest-browser tests at least once).
We must coordinate with QA at the next team meeting to create a test plan for letting this go to release in 57.
Attachment #8886116 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 7•7 years ago
|
||
Try build with all the latest changes is here (based on autoland as that's where they all are): https://treeherder.mozilla.org/#/jobs?repo=try&revision=92d0675c90d26b0856c4cded8093db36e8c4b427
Updated•7 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 8•7 years ago
|
||
Fresh try push with bug 1381027 included:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c837a938564f86772abc9b3a8ba54403902d12b
Assignee | ||
Comment 9•7 years ago
|
||
Looks like we need to resolve bug 1336806 or a variant of it before we can push this.
Comment 10•7 years ago
|
||
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a4690dfd7b3
Enable async PlacesTransactions for nightly builds. r=mak
Comment 11•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Assignee | ||
Updated•7 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Summary: Enable async PlacesTransactions in Nightly → [meta] Enable async PlacesTransactions in Nightly
You need to log in
before you can comment on or make changes to this bug.
Description
•