Mark Banner (:standard8) Assignee
	Description • 9 years ago

When I implemented bug 1142588, I changed the structure of the StandaloneRoomContextView and how the css worked. At the same time, I failed to update the parts for the failure messages, so they now display badly (see attached).

	Mark Banner (:standard8) Assignee
	Comment 1 • 9 years ago

This fixes the issue, the errors are now displayed in the right place & are white.

You can test by setting loop.contextInConverations.enabled to true, restarting, and then generating a new conversation. The conversation url should have a # section, which can be altered or removed to show the error message.

	Mark Banner (:standard8) Assignee
	Comment 2 • 9 years ago

Comment on attachment 8597980 [details] [diff] [review]
Context in conversation errors are not displayed correctly on the standalone UI.

Following discussion earlier, I'm updating this patch

	Mark Banner (:standard8) Assignee
	Comment 3 • 9 years ago

Updated as per the meeting earlier today - the room failure messages are no longer displayed on the UI.

However, since we've got them translated etc, I'm dumping them to the console for now. If we do get into situations where we're not sure why it isn't working, then we should have a way of telling. If later we decide we really do want the messages back, then they aren't far away and we can either restore them or adjust as necessary.

	Dan Mosedale (:dmosedale, :dmose)
	Comment 4 • 9 years ago

Comment on attachment 8598103 [details] [diff] [review]
Don't show errors for context in conversations on the standalone UI as they may force the user into an unnecessary re-obtaining of the URL.

Review of attachment 8598103 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me; r=dmose

	Pulsebot
	Comment 5 • 9 years ago

https://hg.mozilla.org/integration/fx-team/rev/efe637e79d07

	Mark Banner (:standard8) Assignee
	Comment 6 • 9 years ago

Note: I landed it with a minor change to tests - I realised they were expecting the errors to be displayed, so I swapped them to checking that console.error was being logged.

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/efe637e79d07