Closed
Bug 1158884
Opened 9 years ago
Closed 9 years ago
Pocket logic breaks reader view on Android
Categories
(Toolkit :: Reader Mode, defect)
Toolkit
Reader Mode
Tracking
()
People
(Reporter: Margaret, Assigned: Gijs)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
W/GeckoConsole( 6583): [JavaScript Error: "ReferenceError: CustomizableUI is not defined" {file: "resource://gre/modules/AboutReader.jsm" line: 83}]
Assignee | ||
Comment 1•9 years ago
|
||
/r/7695 - Bug 1158884 - hide pocket on android, fix AboutReader.jsm on android, r?margaret
Pull down this commit:
hg pull -r 1be54bde8e374f22e83f73583be6f751e1f096b5 https://reviewboard-hg.mozilla.org/gecko/
Assignee | ||
Updated•9 years ago
|
Attachment #8598095 -
Flags: review?(margaret.leibovic)
Attachment #8598095 -
Flags: feedback?(jaws)
Comment 2•9 years ago
|
||
Comment on attachment 8598095 [details]
MozReview Request: bz://1158884/Gijs
https://reviewboard.mozilla.org/r/7693/#review6461
Ship It!
Attachment #8598095 -
Flags: review+
Updated•9 years ago
|
Attachment #8598095 -
Flags: feedback?(jaws)
Reporter | ||
Comment 3•9 years ago
|
||
Comment on attachment 8598095 [details]
MozReview Request: bz://1158884/Gijs
https://reviewboard.mozilla.org/r/7693/#review6463
r+ with CSS issue addressed.
::: toolkit/components/reader/AboutReader.jsm:94
(Diff revision 1)
> + this._doc.getElementById("pocket-button").hidden = true;
This doesn't appear to properly hide this element...
Looking at our CSS, it appears that the mobile CSS doesn't have the same `.button[hidden]` style that desktop does. Could you just add a rule for that around here somehwere? (I tested this and verified it fixed the problem I'm seeing)
http://mxr.mozilla.org/mozilla-central/source/mobile/android/themes/core/aboutReader.css#314
Attachment #8598095 -
Flags: review?(margaret.leibovic) → review+
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Iteration: --- → 40.2 - 27 Apr
Points: --- → 1
Flags: qe-verify+
Flags: in-testsuite-
Flags: firefox-backlog+
Comment 5•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Updated•9 years ago
|
QA Contact: andrei.vaida
Updated•9 years ago
|
QA Contact: andrei.vaida → teodora.vermesan
Comment 6•9 years ago
|
||
Tested with the 28/04 Nightly build, tapping the reader view icon from URL Bar displayed a blank page.
Tested with the 29/04 Nightly build, pages are correctly displayed in reader view.
Verified as fixed using:
Device: Alcatel One Touch (Android 4.1.2) and Asus Transformer (Android 4.0.3)
Build: Firefox for Android 40.0a1 (2015-04-29)
Status: RESOLVED → VERIFIED
Comment 7•9 years ago
|
||
Comment on attachment 8598095 [details]
MozReview Request: bz://1158884/Gijs
[Triage Comment]
Required for 38.0.5 Pocket launch.
Attachment #8598095 -
Flags: approval-mozilla-release+
Attachment #8598095 -
Flags: approval-mozilla-aurora+
Comment 8•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/cecd2407ef98
https://hg.mozilla.org/releases/mozilla-release/rev/20872d739a18
status-firefox38.0.5:
--- → fixed
status-firefox39:
--- → fixed
Assignee | ||
Comment 9•9 years ago
|
||
Attachment #8598095 -
Attachment is obsolete: true
Attachment #8620164 -
Flags: review+
Assignee | ||
Comment 10•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•