W/GeckoConsole( 6583): [JavaScript Error: "ReferenceError: CustomizableUI is not defined" {file: "resource://gre/modules/AboutReader.jsm" line: 83}]

/r/7695 - Bug 1158884 - hide pocket on android, fix AboutReader.jsm on android, r?margaret Pull down this commit: hg pull -r 1be54bde8e374f22e83f73583be6f751e1f096b5 https://reviewboard-hg.mozilla.org/gecko/

Comment on attachment 8598095 [details] MozReview Request: bz://1158884/Gijs https://reviewboard.mozilla.org/r/7693/#review6461 Ship It!

Comment on attachment 8598095 [details] MozReview Request: bz://1158884/Gijs https://reviewboard.mozilla.org/r/7693/#review6463 r+ with CSS issue addressed. ::: toolkit/components/reader/AboutReader.jsm:94 (Diff revision 1) > + this._doc.getElementById("pocket-button").hidden = true; This doesn't appear to properly hide this element... Looking at our CSS, it appears that the mobile CSS doesn't have the same `.button[hidden]` style that desktop does. Could you just add a rule for that around here somehwere? (I tested this and verified it fixed the problem I'm seeing) http://mxr.mozilla.org/mozilla-central/source/mobile/android/themes/core/aboutReader.css#314

Tested with the 28/04 Nightly build, tapping the reader view icon from URL Bar displayed a blank page. Tested with the 29/04 Nightly build, pages are correctly displayed in reader view. Verified as fixed using: Device: Alcatel One Touch (Android 4.1.2) and Asus Transformer (Android 4.0.3) Build: Firefox for Android 40.0a1 (2015-04-29)

Comment on attachment 8598095 [details] MozReview Request: bz://1158884/Gijs [Triage Comment] Required for 38.0.5 Pocket launch.

https://hg.mozilla.org/releases/mozilla-aurora/rev/cecd2407ef98 https://hg.mozilla.org/releases/mozilla-release/rev/20872d739a18