Closed
Bug 1158885
Opened 9 years ago
Closed 9 years ago
Reader view sanity check test
Categories
(Firefox for Android Graveyard :: Testing, defect)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
Firefox 40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
Attachments
(1 file, 1 obsolete file)
Make sure reader view isn't totally busted.
Assignee | ||
Comment 1•9 years ago
|
||
/r/7709 - Bug 1158885 - Reader view sanity check test. r=mfinkle
Pull down this commit:
hg pull -r 99736bc23efccbf23603c61e60451b5b6895ca09 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8598177 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 2•9 years ago
|
||
This won't pass until bug 1158884 lands.
I also filed bug 1158925 about moving copy/pasted helper functions into a shared place.
Depends on: 1158884
Updated•9 years ago
|
Attachment #8598177 -
Flags: review?(mark.finkle) → review+
Comment 3•9 years ago
|
||
Comment on attachment 8598177 [details]
MozReview Request: bz://1158885/margaret
https://reviewboard.mozilla.org/r/7707/#review6487
Ship It!
Assignee | ||
Comment 4•9 years ago
|
||
Oops, there was actually a JS error in promiseWaitForCondition that caused this to pass locally only because it was causing us to run through the full set of tries before moving on. But on try server this actually failed on 2.3 probably because we're just not waiting long enough. I increased the setInterval time, so maybe that will help, but if this is still orange on 2.3, we may want to disable it there.
Fixing this properly resulted in the visibility tests not passing because we have a timeout to delay the toolbar animation. I decided to avoid scope creep and just get rid of those toolbar visibility checks, since the main point of this test is just to make sure *something* appears in reader view.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6684b02c069c
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Assignee | ||
Comment 7•9 years ago
|
||
Attachment #8598177 -
Attachment is obsolete: true
Attachment #8620165 -
Flags: review+
Assignee | ||
Comment 8•9 years ago
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•